Skip to content

chore: Include flink-metrics-dropwizard that was removed from the Iceberg fat JAR#359

Merged
ferenc-csaky merged 1 commit into
mainfrom
chore/iceberg-metrics
Jul 6, 2026
Merged

chore: Include flink-metrics-dropwizard that was removed from the Iceberg fat JAR#359
ferenc-csaky merged 1 commit into
mainfrom
chore/iceberg-metrics

Conversation

@ferenc-csaky

@ferenc-csaky ferenc-csaky commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

This dep got removed from the Iceberg fat JAR starting with 1.11.0. Without this dep, we'll get warnings in case of an iceberg flink job like:

2026-07-06 12:46:33,738 WARN  org.apache.iceberg.flink.sink.IcebergStreamWriterMetrics     [] - Cannot load Dropwizard metrics; is org.apache.flink:flink-metrics-dropwizard on the classpath?
java.lang.ClassNotFoundException: Cannot find class; alternatives: com.codahale.metrics.Reservoir
	at org.apache.iceberg.common.DynClasses$Builder.buildChecked(DynClasses.java:98) ~[iceberg-flink-runtime-2.1-1.11.0.jar:?]
	at org.apache.iceberg.flink.sink.IcebergStreamWriterMetrics.loadDropwizardCtors(IcebergStreamWriterMetrics.java:134) ~[iceberg-flink-runtime-2.1-1.11.0.jar:?]
	at org.apache.iceberg.flink.sink.IcebergStreamWriterMetrics.<clinit>(IcebergStreamWriterMetrics.java:46) ~[iceberg-flink-runtime-2.1-1.11.0.jar:?]
	at org.apache.iceberg.flink.sink.IcebergSink.createWriter(IcebergSink.java:228) ~[iceberg-flink-runtime-2.1-1.11.0.jar:?]
	at org.apache.flink.streaming.runtime.operators.sink.StatelessSinkWriterStateHandler.createWriter(StatelessSinkWriterStateHandler.java:39) ~[flink-dist-2.2.1.jar:2.2.1]
	at org.apache.flink.streaming.runtime.operators.sink.SinkWriterOperator.initializeState(SinkWriterOperator.java:171) ~[flink-dist-2.2.1.jar:2.2.1]
	at org.apache.flink.streaming.api.operators.StreamOperatorStateHandler.initializeOperatorState(StreamOperatorStateHandler.java:142) ~[flink-dist-2.2.1.jar:2.2.1]
	at org.apache.flink.streaming.api.operators.AbstractStreamOperator.initializeState(AbstractStreamOperator.java:308) ~[flink-dist-2.2.1.jar:2.2.1]
	at org.apache.flink.streaming.runtime.tasks.RegularOperatorChain.initializeStateAndOpenOperators(RegularOperatorChain.java:106) ~[flink-dist-2.2.1.jar:2.2.1]
	at org.apache.flink.streaming.runtime.tasks.StreamTask.restoreStateAndGates(StreamTask.java:866) ~[flink-dist-2.2.1.jar:2.2.1]
	at org.apache.flink.streaming.runtime.tasks.StreamTask.lambda$restoreInternal$5(StreamTask.java:820) ~[flink-dist-2.2.1.jar:2.2.1]
	at org.apache.flink.streaming.runtime.tasks.StreamTaskActionExecutor$1.call(StreamTaskActionExecutor.java:55) ~[flink-dist-2.2.1.jar:2.2.1]
	at org.apache.flink.streaming.runtime.tasks.StreamTask.restoreInternal(StreamTask.java:820) ~[flink-dist-2.2.1.jar:2.2.1]
	at org.apache.flink.streaming.runtime.tasks.StreamTask.restore(StreamTask.java:779) ~[flink-dist-2.2.1.jar:2.2.1]
	at org.apache.flink.runtime.taskmanager.Task.runWithSystemExitMonitoring(Task.java:973) [flink-dist-2.2.1.jar:2.2.1]
	at org.apache.flink.runtime.taskmanager.Task.restoreAndInvoke(Task.java:945) [flink-dist-2.2.1.jar:2.2.1]
	at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:760) [flink-dist-2.2.1.jar:2.2.1]
	at org.apache.flink.runtime.taskmanager.Task.run(Task.java:569) [flink-dist-2.2.1.jar:2.2.1]
	at java.base/java.lang.Thread.run(Thread.java:840) [?:?]

It doesn't disrupt anything regarding the deployment, but without it, iceberg file-size histogram metrics won't be collected.

@ferenc-csaky ferenc-csaky requested a review from mateczagany July 6, 2026 14:15
@ferenc-csaky ferenc-csaky added this to the 0.10.5 milestone Jul 6, 2026
@ferenc-csaky ferenc-csaky removed this from the 0.10.5 milestone Jul 6, 2026
@ferenc-csaky ferenc-csaky merged commit 459c5b3 into main Jul 6, 2026
13 checks passed
@ferenc-csaky ferenc-csaky deleted the chore/iceberg-metrics branch July 6, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flink-metrics-dropwizard missing from test runner classpath causes Iceberg sink WARN on startup

2 participants