Fix .Q.lim[] dict access for KDB-X Community edition connection limit…#738
Open
fd98279 wants to merge 1 commit intoDataIntellectTech:masterfrom
Open
Fix .Q.lim[] dict access for KDB-X Community edition connection limit…#738fd98279 wants to merge 1 commit intoDataIntellectTech:masterfrom
fd98279 wants to merge 1 commit intoDataIntellectTech:masterfrom
Conversation
… check .Q.lim[] returns a dict `cur`lim!N N in KDB-X, not a scalar. The condition `0W=.Q.lim[][`conns]` compared 0W against the whole dict, which always evaluates false causing discovery to be enabled even under connection limits. Fix: use `x[`conns][`lim]` to extract the scalar limit value so the comparison works correctly. With lim=8: `0W=8` → 0b → discovery disabled. Affects: - config/settings/default.q (DISCOVERYCONNECT) - config/settings/segmentedchainedtickerplant.q (CONNECTIONSFROMDISCOVERY)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.Q.lim[] returns a dict
curlim!N N in KDB-X, not a scalar. The condition0W=.Q.lim[][conns]` compared 0W against the whole dict, which always evaluates false causing discovery to be enabled even under connection limits.q).Q.lim[]
| cur lim
----- | ---------
cores | 10 0W
threads| 0 4
mem | 64 16384
conns | 1 8
q).Q.lim[][
conns][lim]8
q)0W=.Q.lim[][
conns][lim]0b
Fix: use
x[conns][lim]to extract the scalar limit value so thecomparison works correctly. With lim=8:
0W=8→ 0b → discovery disabled.Affects: