Repository navigation
Conversation
Keep environment validation while allowing the dependent-flag capability parameter. Cover successful configuration, authorization responses, and invalid environments with capability negotiation enabled. Environment: Datadog workspace Co-Authored-By: Codex GPT-6 <noreply@localhost>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: d70adde | Docs | View more details | Give us feedback! |
Synchronize the generated mirror manifest and locked digests with the PHP base image tags used by the scenarios so the GitLab freshness check passes. Environment: Datadog workspace Co-Authored-By: Codex GPT-6 <noreply@localhost>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agentless clients advertising
cap_dependent-flags-variant-key=v1receive HTTP 404 from the mock backend because its environment check compares the entire query dictionary. This causes configuration-source tests to remainPROVIDER_NOT_READYdespite valid requests.Allow that capability parameter alongside the required
dd_env=test, preserving rejection of missing, invalid, or repeated environment values. Parameterize the existing backend test to verify configuration delivery, request accounting, and 401 responses with and without capability metadata.Validation:
352cbe0../format.shpasses, including mypy, import policy, Python/YAML formatters, parser checks, and shellcheck.