Repository navigation
Conversation
Refresh the canonical dependent-flags suite from ffe-system-test-data PR #71 for the existing shared SDK harness. Environment: Datadog workspace Co-Authored-By: Codex GPT-6 <noreply@localhost>
Contributor
|
|
hhan2024
marked this pull request as ready for review
November 5, 2026 22:39
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imports canonical fixture PR DataDog/ffe-system-test-data#71 at
fdd48ad2dc30cee7819b3aafb883d1edcd2455dbinto the existing shared SDK test harness. The new case requires unknown fields insideflagEvaluation, on its condition, and inevaluatorParamsto be ignored while returning the expected dependent assignment.The snapshot was generated with
python3 utils/scripts/update_ffe_fixtures.py --ref fdd48ad2dc30cee7819b3aafb883d1edcd2455db. A second run reportschanged: false. The diff contains only the dependent suite UFC, its case file, and source provenance. Existing manifests and SDK activation gates are preserved; current main asserts assignment results, while telemetry expectations are consumed by the separate telemetry harness PR #8051.Validation:
./format.shpassed; all four required review lenses and standard self-review found no actionable issues. Fixture validation and 19 validator tests passed in the canonical PR. Cross-SDK runtime execution is pending; implementations that reject extra reference fields should fail the new case.Merge the canonical fixture PR first and refresh this pin to its merged revision before landing this snapshot. This test is separate from DataDog/libdatadog#2748.