Repository navigation
[.NET] Use the informational version as the parametric library version - #8374
Open
andrewlock wants to merge 1 commit into
Open
andrewlock wants to merge 1 commit into
andrewlock wants to merge 1 commit into
Conversation
The assembly version of Datadog.Trace is the same for a prerelease and its release (e.g. 3.58.0.0), but the tracer reports the semantic version (3.58.0-prerelease), so process discovery tests failed for prereleases. Read AssemblyInformationalVersion instead, without its +<commit> build metadata, falling back to the assembly version. Releases are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 7fbfc45 | Docs | View more details | Give us feedback! |
Contributor
|
|
andrewlock
marked this pull request as ready for review
November 5, 2026 17:17
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The .NET SDK now uses the full semantic version, instead of the "assembly" version it was used before
Changes
The assembly version of Datadog.Trace is the same for a prerelease and its release (e.g. 3.58.0.0), but the tracer reports the semantic version (3.58.0-prerelease), so process discovery tests failed for prereleases. Read
AssemblyInformationalVersioninstead, without its+<commit>build metadata, falling back to the assembly version. Non pre-releases/dev builds are unaffectedWorkflow
system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.system-tests-core(slack)🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟