Repository navigation
test(ffe): apply server flag selection in the mocked backend #8304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mark-caii
wants to merge
13
commits into
main
Choose a base branch
from
mark.cai/FFL-3567
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7ccd5f4
test(ffe): apply server flag selection in the mocked backend
mark-caii 32323a3
test(ffe): vendor only the selection vectors and UFC tags
mark-caii c3aad38
test(ffe): serve selections with non-UTF-8 values in the mocked backend
mark-caii 10b7bdc
test(ffe): send the flag selection in its own ffe_start field
mark-caii ed97cad
test(ffe): revalidate selected configurations with their own ETag
mark-caii ae0d638
Merge branch main into mark.cai/FFL-3567
mark-caii 058ed8b
test(ffe): run the flag-selection evaluation suite
mark-caii 4b7487c
test(ffe): revalidate ignored selections and check vendored selection…
mark-caii 358e5e2
test(ffe): pin selection ETags and the revalidation query, refresh fi…
mark-caii d56b7f7
Merge branch main into mark.cai/FFL-3567
mark-caii c7e5688
Merge branch main into mark.cai/FFL-3567
mark-caii ee7a9d0
test(ffe): check suite case files and canonical selections against th…
mark-caii 8654fb2
test(ffe): refresh fixtures with the at-limits and no-match selection…
mark-caii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
148 changes: 148 additions & 0 deletions
148
.../test_ffe/ffe-system-test-data/evaluation-suites/flag-selection/cases/canonical-form.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,148 @@ | ||
| [ | ||
| { | ||
| "description": "Selected by tag team:checkout.", | ||
| "flag": "checkout-banner", | ||
| "variationType": "BOOLEAN", | ||
| "defaultValue": false, | ||
| "targetingKey": "alice", | ||
| "attributes": {}, | ||
| "providerOptions": { | ||
| "flagSelection": { | ||
| "tags": [" team:search ", "team:checkout", "team:search", ""], | ||
| "keyPatterns": ["\tops-*", "ops-*", "billing-*", ""] | ||
| } | ||
| }, | ||
| "expectations": { | ||
| "configurationRequest": { | ||
| "selectedFlagTags": ["team:checkout", "team:search"], | ||
| "selectedFlagKeyPatterns": ["billing-*", "ops-*"] | ||
| } | ||
| }, | ||
| "result": { | ||
| "value": true, | ||
| "reason": "STATIC" | ||
| } | ||
| }, | ||
| { | ||
| "description": "Selected by tag team:checkout.", | ||
| "flag": "checkout-pricing", | ||
| "variationType": "BOOLEAN", | ||
| "defaultValue": false, | ||
| "targetingKey": "alice", | ||
| "attributes": {}, | ||
| "providerOptions": { | ||
| "flagSelection": { | ||
| "tags": [" team:search ", "team:checkout", "team:search", ""], | ||
| "keyPatterns": ["\tops-*", "ops-*", "billing-*", ""] | ||
| } | ||
| }, | ||
| "expectations": { | ||
| "configurationRequest": { | ||
| "selectedFlagTags": ["team:checkout", "team:search"], | ||
| "selectedFlagKeyPatterns": ["billing-*", "ops-*"] | ||
| } | ||
| }, | ||
| "result": { | ||
| "value": true, | ||
| "reason": "STATIC" | ||
| } | ||
| }, | ||
| { | ||
| "description": "Selected by tag team:search.", | ||
| "flag": "search-ranking", | ||
| "variationType": "BOOLEAN", | ||
| "defaultValue": false, | ||
| "targetingKey": "alice", | ||
| "attributes": {}, | ||
| "providerOptions": { | ||
| "flagSelection": { | ||
| "tags": [" team:search ", "team:checkout", "team:search", ""], | ||
| "keyPatterns": ["\tops-*", "ops-*", "billing-*", ""] | ||
| } | ||
| }, | ||
| "expectations": { | ||
| "configurationRequest": { | ||
| "selectedFlagTags": ["team:checkout", "team:search"], | ||
| "selectedFlagKeyPatterns": ["billing-*", "ops-*"] | ||
| } | ||
| }, | ||
| "result": { | ||
| "value": true, | ||
| "reason": "STATIC" | ||
| } | ||
| }, | ||
| { | ||
| "description": "Not selected: it has no selected tag and matches no key pattern, so the server omits it.", | ||
| "flag": "summer-sale", | ||
| "variationType": "BOOLEAN", | ||
| "defaultValue": false, | ||
| "targetingKey": "alice", | ||
| "attributes": {}, | ||
| "providerOptions": { | ||
| "flagSelection": { | ||
| "tags": [" team:search ", "team:checkout", "team:search", ""], | ||
| "keyPatterns": ["\tops-*", "ops-*", "billing-*", ""] | ||
| } | ||
| }, | ||
| "expectations": { | ||
| "configurationRequest": { | ||
| "selectedFlagTags": ["team:checkout", "team:search"], | ||
| "selectedFlagKeyPatterns": ["billing-*", "ops-*"] | ||
| } | ||
| }, | ||
| "result": { | ||
| "value": false, | ||
| "reason": "ERROR", | ||
| "errorCode": "FLAG_NOT_FOUND" | ||
| } | ||
| }, | ||
| { | ||
| "description": "Selected by key pattern ops-*.", | ||
| "flag": "ops-kill-switch", | ||
| "variationType": "BOOLEAN", | ||
| "defaultValue": false, | ||
| "targetingKey": "alice", | ||
| "attributes": {}, | ||
| "providerOptions": { | ||
| "flagSelection": { | ||
| "tags": [" team:search ", "team:checkout", "team:search", ""], | ||
| "keyPatterns": ["\tops-*", "ops-*", "billing-*", ""] | ||
| } | ||
| }, | ||
| "expectations": { | ||
| "configurationRequest": { | ||
| "selectedFlagTags": ["team:checkout", "team:search"], | ||
| "selectedFlagKeyPatterns": ["billing-*", "ops-*"] | ||
| } | ||
| }, | ||
| "result": { | ||
| "value": true, | ||
| "reason": "STATIC" | ||
| } | ||
| }, | ||
| { | ||
| "description": "Not selected: it has no selected tag and matches no key pattern, so the server omits it.", | ||
| "flag": "untagged-flag", | ||
| "variationType": "BOOLEAN", | ||
| "defaultValue": false, | ||
| "targetingKey": "alice", | ||
| "attributes": {}, | ||
| "providerOptions": { | ||
| "flagSelection": { | ||
| "tags": [" team:search ", "team:checkout", "team:search", ""], | ||
| "keyPatterns": ["\tops-*", "ops-*", "billing-*", ""] | ||
| } | ||
| }, | ||
| "expectations": { | ||
| "configurationRequest": { | ||
| "selectedFlagTags": ["team:checkout", "team:search"], | ||
| "selectedFlagKeyPatterns": ["billing-*", "ops-*"] | ||
| } | ||
| }, | ||
| "result": { | ||
| "value": false, | ||
| "reason": "ERROR", | ||
| "errorCode": "FLAG_NOT_FOUND" | ||
| } | ||
| } | ||
| ] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.