Repository navigation
test(ffe): register dependent flag RC capability - #8293
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoNov 2, 2026
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
Recognize capability bit 50 when validating tracer Remote Configuration requests. Environment: Datadog workspace Co-Authored-By: Codex GPT-6 <noreply@localhost>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
|
hhan2024
added a commit
to DataDog/dd-trace-py
that referenced
this pull request
Nov 2, 2026
Pin the shared harness revision that registers RC capability bit 50, fixing parametric capability validation failures in GitHub and GitLab CI. System-tests fix: DataDog/system-tests#8293 Environment: Datadog workspace Co-Authored-By: Codex GPT-6 <noreply@localhost>
cbeauchesne
approved these changes
Nov 2, 2026
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 6883a96 | Docs | View more details | Give us feedback! |
gh-worker-dd-mergequeue-cf854d
Bot
merged commit Nov 2, 2026
5afca22
into
main
3049 of 3051 checks passed
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
helen/fix-dependent-flags-rc-capability
branch
November 2, 2026 20:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is needed to fix test failures now that DataDog/libdatadog#2745 is merged: Register
FFE_FLAG_DEPENDENT_FLAG_VARIANT_KEY_V1at Remote Configuration capability bit 50.Tracers implementing dependent flags advertise this bit; the capability validator currently rejects it as unknown, causing unrelated dynamic-configuration and feature-flag source-selection tests to fail.
This fixes the shared harness failure seen in DataDog/dd-trace-py#21346 (11 parametric test failures). Unknown bits and the 64-bit limit remain validated.
Validation:
./format.shpasses. ExercisedTestAgentAPI.wait_for_rc_capabilitieswith mocked RC responses: bit 50 alone and combined with existing bits decode in both base64 and byte-array formats; bit 51 and oversized masks remain rejected. Full parametric CI remains to run.