Repository navigation
test(ffe): enable experimentation opt-out mode coverage for Go and Java - #8244
Draft
leoromanovsky wants to merge 12 commits into
Draft
leoromanovsky wants to merge 12 commits into
leoromanovsky wants to merge 12 commits into
Conversation
Replace local fixture copies with the shared corpus, preserve extracted metadata and span inputs, and add a reviewed snapshot update workflow. Environment: Datadog workspace
Expose Node.js error codes and Ruby resolution details to canonical assertions. Convert Ruby numeric defaults to Float before calling the OpenFeature client. Environment: Datadog workspace
Keep the unified FFE mock backend loading the canonical fixture snapshot and preserve updater ownership. Environment: Datadog workspace
Co-authored-by: Codex GPT-5 <noreply@localhost>
Preserve the canonical FFE fixture path through the mock backend container refactor and retain the merged platform applicability filters. Environment: Datadog workspace
Download dd-openfeature.jar from the selected Java snapshot branch so FFE tests do not pair the development agent with an incompatible release provider. Cover default and custom branches, Java Lambda, and missing providers. Environment: Datadog workspace
Preserve canonical fixture discovery and platform filters. Keep the development OpenFeature provider out of Java Lambda builds, cover both loader paths, and document unasserted split-feature metadata.
The 0.5.4 release moved back to OpenTelemetry 0.32, which lacks the compression fallback and scope schema URL behavior present in 0.33. Preserve the existing minimum versions and declare only the released 0.5.4 unsupported; keep the 0.5.4 development build enabled. Environment: Datadog workspace
Exercise canonical capability expectations with disabled, immediate, and future-only process settings. Activate the validated development versions and document pending SDK dependencies. Environment: Datadog workspace
Contributor
|
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)❄️ No new flaky tests detected Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 052a944 | Docs | View more details | Give us feedback! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Subjects who opt out of experimentation must retain ordinary feature delivery, and future-only opt-out must retain experiments activated before their cutoff. The canonical suite currently reads baseline results without enabling either opt-out mode, so it cannot catch regressions in these policies.
Changes
Run the immutable canonical opt-out cases in four separate application configurations: default-disabled, explicit disabled,
immediate, andfuture_experiments_only. Enabled modes use their capability-specific expectations and assert values, reasons, and error codes, including invalid contexts, cutoff equality, unknown activation, and ordinary allocations. The settleddoLogbehavior is unchanged.Enable this suite from Go
2.13.0-devand Java1.69.0-SNAPSHOT. Go's merge already contains both modes;v2.12.0-rc.1does not. Java activation depends on dd-trace-java#12950. Other SDK manifests identify their pending implementation or dependency requirements instead of claiming unsupported coverage. These are development-build thresholds, not stable-release claims.Stacked on canonical fixtures #8139. Merge after that parent and the Java implementation. The existing evaluation-telemetry opt-out scenarios are separate and unchanged.
Validation
Normal manifest activation, without
--runxfail: 8 configurations passed, 320 canonical evaluations, zero skips or expected failures.2.13.0-devfd09513977a448b87ca402252944a2c55d81eb011.69.0-SNAPSHOTcandidate22bc2619cec98102c24b6c9eb1060cd8378ba1feBoth enabled-mode Java negative controls failed when the application was forced to disable opt-out; the restored tests pass. Repository formatting, typing, import, manifest, shell, and Node checks pass. Java artifacts were built from the changes committed at the listed revision and carry the parent build tag
+88354535bf.This validates local public-provider evaluation through Remote Config. Exposure/evaluation delivery, standalone transport, other SDKs, and hosted CI are not covered by these runs.
Workflow
system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.system-tests-core(slack)🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟