Skip to content

[php@typo/dependent-flags-returned-batch] [FFL-1694] test(php): activate dependent flag coverage - #8231

Draft
typotter wants to merge 1 commit into
dependent-flags-variant-key-telemetryfrom
typo/activate-dependent-flags-php
Draft

typotter wants to merge 1 commit into
dependent-flags-variant-key-telemetryfrom
typo/activate-dependent-flags-php

Conversation

@typotter

@typotter typotter commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Run the canonical dependent-flags feature suite against the latest PHP implementation through its tracer SDK artifact.

Changes

Validation:

  • ./format.sh — passed for the manifest-only change
  • git diff --check — passed
  • effective PR diff is one line in the PHP manifest
  • branch-targeted system-tests CI exercises the imported canonical result and telemetry contracts

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Tests, manifest, weblog are modified -> you'll need a review from system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.
    • Framework is modified, or non obvious usage of it -> get a review from system-tests-core (slack)

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

@linear-code

linear-code Bot commented Oct 29, 2026

Copy link
Copy Markdown

FFL-1694

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/php.yml                                                       @DataDog/system-tests-reviewers

@datadog-official

datadog-official Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Tests

🎉 All green!

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a577484 | Docs | View more details | Give us feedback!

@typotter
typotter force-pushed the typo/activate-dependent-flags-php branch 2 times, most recently from a4d5a92 to 52bb694 Compare October 30, 2026 20:18
@typotter
typotter changed the base branch from main to ffe-import-feature-suites October 30, 2026 20:19
@typotter
typotter force-pushed the typo/activate-dependent-flags-php branch from 52bb694 to a088e9e Compare October 30, 2026 20:29
@typotter
typotter changed the base branch from ffe-import-feature-suites to dependent-flags-variant-key-telemetry October 30, 2026 20:30
@typotter
typotter force-pushed the dependent-flags-variant-key-telemetry branch 3 times, most recently from a4767e8 to 2d637a9 Compare November 3, 2026 19:46
@typotter typotter closed this Nov 3, 2026
@typotter
typotter force-pushed the typo/activate-dependent-flags-php branch from a088e9e to 8355d07 Compare November 3, 2026 19:48
Activate the imported canonical dependent-flags feature suite for the targeted PHP SDK development version.

Environment: Datadog workspace

Co-Authored-By: Codex GPT-5 <noreply@localhost>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant