[nodejs@typo/dependent-flags-evaluator-system-tests] [FFL-1694] test(nodejs): activate dependent flag coverage by typotter · Pull Request #8050 · DataDog/system-tests

typotter · 2026-10-14T16:08:44Z

Motivation

Run the canonical dependent-flags feature suite against the latest Node.js implementation through its tracer SDK artifact.

Changes

activate Test_Feature_Flag_Dynamic_Evaluation.test_ffe_dependent_flags for Node.js at >=5.77.0
target DataDog/dd-trace-js#typo/dependent-flags-evaluator-system-tests through the system-tests PR-title override
consume the feature-suite importer from test(ffe): import canonical feature suites #8260 and telemetry assertions from [FFL-1694] test(ffe): validate dependent flag telemetry #8051
keep the activation layer to one manifest declaration

Validation:

./format.sh — passed for the manifest-only change
git diff --check — passed
effective PR diff is one line in the Node.js manifest
branch-targeted system-tests CI exercises the imported canonical result and telemetry contracts

Workflow

⚠️ Create your PR as draft ⚠️
Work on you PR until the CI passes
Mark it as ready for review
- Tests, manifest, weblog are modified -> you'll need a review from system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.
- Framework is modified, or non obvious usage of it -> get a review from system-tests-core (slack)

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

linear-code · 2026-10-14T16:08:53Z

FFL-1694

github-actions · 2026-10-14T16:09:11Z

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/system-tests-reviewers

datadog-datadog-prod-us1-2 · 2026-10-14T16:14:19Z

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 38f474e | Docs | View more details | Give us feedback!}

Copilot

🟡 Changes recommended

The version gate enables assertions on SDK releases that predate dependent-flag support.

1 open finding

Gate express5 on the SDK's first supported version · New

What changed in this PR

Activates the dependent-flag evaluation and telemetry coverage from #8049 and #8051 for the Node.js Express5 weblog.

Changes:

Enables dependent-flag tests for Express5 using a version gate.
Marks all other Node.js weblogs as incomplete_test_app.

File	Description
manifests/nodejs.yml	Adds weblog-specific activation for dependent-flag tests.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

chatgpt-codex-connector · 2026-10-20T16:38:18Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-20T16:40:04.431581Z	`aad825f`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot

🔵 Needs a closer look

Final approval needs confirmation of integration-branch CI results and resolution of the intentional branch-override merge guard.

1 open issue

Gate express5 on the SDK's first supported version

_{Review effort: Balanced}

Carry Leo's canonical corpus base and the supplemental dependent telemetry coverage through #8050 while preserving the Node v7 pre-release activation. Environment: Datadog workspace Co-Authored-By: Codex GPT-5 <noreply@localhost>

Copilot

🔵 Needs a closer look

Human confirmation is needed for the matching tracer integration and the intentionally failing target-branch CI guard.

1 open issue

Gate express5 on the SDK's first supported version

_{Review effort: Balanced}

Copilot

🟢 Approval recommended

The narrow manifest change resolves the earlier activation issue while preserving deactivation for unsupported v5/v6 releases.

No open issues 🎉

1 resolved since last review

Gate express5 on the SDK's first supported version

_{Review effort: Balanced}

Copilot

🔵 Needs a closer look

The telemetry drain barrier depends on SDK writer-ordering guarantees that still need confirmation against the integration branch.

No open issues 🎉

_{Review effort: Balanced}

Copilot

🔵 Needs a closer look

The telemetry drain check depends on SDK writer ordering that remains unverified and needs human confirmation.

No open issues 🎉

_{Review effort: Balanced}

Activate the imported canonical dependent-flags feature suite for the targeted Node.js SDK development version. Environment: Datadog workspace Co-Authored-By: Codex GPT-5 <noreply@localhost>

This was referenced Oct 14, 2026

feat(openfeature): support dependent flag evaluation DataDog/dd-trace-js#10749

Draft

[FFL-1694] test(ffe): add dependent flag evaluation coverage #8049

Closed

typotter force-pushed the dependent-flags-variant-key-e2e branch from 0f79993 to 5a23492 Compare October 14, 2026 16:58

typotter mentioned this pull request Oct 14, 2026

[FFL-1694] test(ffe): validate dependent flag telemetry #8051

Open

typotter force-pushed the dependent-flags-variant-key-e2e branch from 5a23492 to 5fcbf37 Compare October 14, 2026 17:05

typotter force-pushed the dependent-flags-variant-key-node-activation branch from 9caf914 to 9043eb9 Compare October 14, 2026 17:09

typotter changed the base branch from dependent-flags-variant-key-e2e to dependent-flags-variant-key-telemetry October 14, 2026 17:10

typotter force-pushed the dependent-flags-variant-key-telemetry branch from 1844814 to 91a38de Compare October 14, 2026 17:23

typotter force-pushed the dependent-flags-variant-key-node-activation branch from 9043eb9 to 4f32a87 Compare October 14, 2026 17:25

typotter requested a balanced review from Copilot October 14, 2026 18:05

Copilot started reviewing on behalf of typotter October 14, 2026 18:06

View session

Copilot AI reviewed Oct 14, 2026

View reviewed changes

Comment thread manifests/nodejs.yml Resolved

typotter force-pushed the dependent-flags-variant-key-telemetry branch from 91a38de to 35e691d Compare October 14, 2026 18:20

typotter force-pushed the dependent-flags-variant-key-node-activation branch from 4f32a87 to 03216e4 Compare October 14, 2026 18:21

typotter force-pushed the dependent-flags-variant-key-telemetry branch from 35e691d to b9eaaf4 Compare October 15, 2026 05:19

typotter force-pushed the dependent-flags-variant-key-node-activation branch 2 times, most recently from da66404 to 9d59ef1 Compare October 15, 2026 05:21

typotter marked this pull request as ready for review October 20, 2026 16:38

typotter requested a review from a team as a code owner October 20, 2026 16:38

typotter requested a review from leoromanovsky October 20, 2026 16:38

leoromanovsky approved these changes Oct 21, 2026

View reviewed changes

typotter requested a balanced review from Copilot October 21, 2026 20:31

Copilot started reviewing on behalf of typotter October 21, 2026 20:31

View session

Copilot AI reviewed Oct 21, 2026

View reviewed changes

typotter requested a balanced review from Copilot October 21, 2026 20:57

Copilot started reviewing on behalf of typotter October 21, 2026 20:58

View session

Copilot AI reviewed Oct 21, 2026

View reviewed changes

typotter marked this pull request as draft October 21, 2026 21:28

typotter requested a balanced review from Copilot October 21, 2026 21:42

Copilot started reviewing on behalf of typotter October 21, 2026 21:42

View session

Copilot AI reviewed Oct 21, 2026

View reviewed changes

typotter requested a balanced review from Copilot October 21, 2026 22:11

Copilot started reviewing on behalf of typotter October 21, 2026 22:11

View session

Copilot AI reviewed Oct 21, 2026

View reviewed changes

typotter requested a balanced review from Copilot October 22, 2026 06:45

Copilot started reviewing on behalf of typotter October 22, 2026 06:45

View session

Copilot AI reviewed Oct 22, 2026

View reviewed changes

typotter changed the base branch from dependent-flags-variant-key-telemetry to typo/dependent-flags-direct-system-tests October 27, 2026 21:08

Base automatically changed from typo/dependent-flags-direct-system-tests to main October 28, 2026 17:09

typotter force-pushed the dependent-flags-variant-key-node-activation branch from 0e28895 to ef29e10 Compare October 28, 2026 22:22

typotter changed the title ~~[nodejs@dependent-flags-variant-key-node-integration] [FFL-1694] test(nodejs): activate dependent flag coverage~~ [nodejs@typo/dependent-flags-evaluator-system-tests] [FFL-1694] test(nodejs): activate dependent flag coverage Oct 28, 2026

typotter force-pushed the dependent-flags-variant-key-node-activation branch from 14b0e89 to fde9513 Compare October 30, 2026 20:19

typotter changed the base branch from main to ffe-import-feature-suites October 30, 2026 20:19

typotter force-pushed the dependent-flags-variant-key-node-activation branch from fde9513 to 2936bfb Compare October 30, 2026 20:30

typotter changed the base branch from ffe-import-feature-suites to dependent-flags-variant-key-telemetry October 30, 2026 20:30

typotter force-pushed the dependent-flags-variant-key-telemetry branch 3 times, most recently from a4767e8 to 2d637a9 Compare November 3, 2026 19:46

typotter closed this Nov 3, 2026

typotter force-pushed the dependent-flags-variant-key-node-activation branch from 2936bfb to 8355d07 Compare November 3, 2026 19:48

test(node): activate dependent flag coverage

38f474e

Activate the imported canonical dependent-flags feature suite for the targeted Node.js SDK development version. Environment: Datadog workspace Co-Authored-By: Codex GPT-5 <noreply@localhost>

typotter reopened this Nov 3, 2026

Navigation Menu

Repository navigation

[nodejs@typo/dependent-flags-evaluator-system-tests] [FFL-1694] test(nodejs): activate dependent flag coverage - #8050

[nodejs@typo/dependent-flags-evaluator-system-tests] [FFL-1694] test(nodejs): activate dependent flag coverage#8050
typotter wants to merge 1 commit into
dependent-flags-variant-key-telemetryfrom
dependent-flags-variant-key-node-activation

typotter commented Oct 14, 2026 •

edited

Loading

Uh oh!

linear-code Bot commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Oct 14, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

typotter commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Workflow

Uh oh!

linear-code Bot commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typotter commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

datadog-datadog-prod-us1-2 Bot commented Oct 14, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 20, 2026 •

edited

Loading