Repository navigation
chore(codeowners): make FFE own its test endpoints - #7861
Merged
Merged
Conversation
Contributor
|
|
pavlokhrebto
changed the title
pavlokhrebto
marked this pull request as ready for review
September 30, 2026 10:14
cbeauchesne
approved these changes
Oct 1, 2026
leoromanovsky
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some files in
utils/build/docker/exist only for Feature Flags tests. They fall under the/utils/build/docker/rule, so@DataDog/system-tests-reviewersowns them and FFE does not review changes to its own test endpoints. The FFE tests (tests/ffe/,tests/parametric/test_ffe/) are already FFE-owned.Changes
Make
@DataDog/feature-flagging-and-experimentation-sdkco-own, with@DataDog/system-tests-core, the remaining six FFE-dedicated endpoint files:golang/app/_shared/common/ffe.gogolang/parametric/ffe.gojava/parametric/.../FeatureFlagEvaluatorController.javajava/spring-boot/.../featureflag/FeatureFlagEvaluatorController.javanodejs/nextjs/src/app/ffe/route.jsphp/common/ffe.phpThe two dotnet files were already added in #7496. Shared files that only contain an FFE route or a package reference (
app.js,server.py,main.go,.csproj,package.json, requirements files) are left as they are, so FFE does not become a required reviewer for unrelated changes.The new lines are in the
# FFEsection, after the/utils/build/docker/rule, so they take precedence.Workflow
system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.system-tests-core(slack)🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟