Base image build process#7270
Draft
nccatoni wants to merge 7 commits into
Draft
Conversation
Base images will now be tagged with a content hash appended by utils/scripts/build_base_images.py.
Contributor
|
|
Adds build_base_images.py, which for every docker-bake.hcl target listed under base_image_dependencies in a library's weblog_metadata.yml, hashes the target's bake config, Dockerfile, and declared dependencies, and pushes the base image to Docker Hub tagged with that hash if missing. Wires it up as a build_base_images job in .gitlab-ci.yml, running on every push. It is idempotent: existing tags are never overwritten, so it is safe to run ahead of merge.
nccatoni
force-pushed
the
nccatoni/base-image-build
branch
from
a750a56 to
e2c8ca6
Compare
nccatoni
force-pushed
the
nccatoni/base-image-build
branch
from
e2c8ca6 to
611f535
Compare
🎉 All green!🧪 All tests passed 🔄 Datadog auto-retried 1 job - 1 passed on retry 🔗 Commit SHA: 0797a09 | Docs | Datadog PR Page | Give us feedback! |
Previously image_exists() silently treated any docker manifest inspect failure as "tag doesn't exist", masking real errors (auth, network). Print stderr on failure there, and in a new _run() helper used by the other docker/git subprocess calls, so failures are visible instead of only raising a bare CalledProcessError.
nccatoni
force-pushed
the
nccatoni/base-image-build
branch
from
f25de84 to
0beb187
Compare
composer install failed for php-fpm targets because stripe/stripe-php requires ext-mbstring, which wasn't installed. apache-mod targets were unaffected since they use the official PHP image, which bundles it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present