Skip to content

ffe/go: enable span enrichment tests#7125

Draft
dd-oleksii wants to merge 2 commits into
mainfrom
oleksii/jj-mlzqxpztyuqk
Draft

ffe/go: enable span enrichment tests#7125
dd-oleksii wants to merge 2 commits into
mainfrom
oleksii/jj-mlzqxpztyuqk

Conversation

@dd-oleksii

Copy link
Copy Markdown
Member

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
utils/build/docker/golang/parametric/ffe.go                             @DataDog/dd-trace-go-guild @DataDog/system-tests-core

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 10, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 3 Pipeline jobs failed

Testing the test | System Tests (python, dev) / End-to-end #1 / uwsgi-poc 1   View in Datadog   GitHub Actions

🧪 1 Test failed

tests.appsec.iast.sink.test_unvalidated_redirect.TestUnvalidatedRedirect.test_secure[uwsgi-poc] from system_tests_suite   View in Datadog
ValueError: Unexpected vulnerability reported: UNVALIDATED_REDIRECT

self = <tests.appsec.iast.sink.test_unvalidated_redirect.TestUnvalidatedRedirect object at 0x7fb7f1c472f0>

    def test_secure(self):
>       super().test_secure()

tests/appsec/iast/sink/test_unvalidated_redirect.py:47: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/appsec/iast/utils.py:186: in test_secure
...

Testing the test | System Tests (python, prod) / End-to-end #1 / uwsgi-poc 1   View in Datadog   GitHub Actions

🧪 1 Test failed

tests.test_telemetry.Test_Telemetry.test_app_heartbeats_delays[uwsgi-poc] from system_tests_suite   View in Datadog
AssertionError: Heartbeat sent too fast: 1.0199575s. It should be sent every 2s
assert 1.0199575 > 1.5

self = <tests.test_telemetry.Test_Telemetry object at 0x7fa512ee5f10>

    @features.telemetry_heart_beat_collected
    def test_app_heartbeats_delays(self):
        """Check for telemetry heartbeat are not sent too fast/slow, regarding DD_TELEMETRY_HEARTBEAT_INTERVAL
        There are a lot of reason for individual heartbeats to be sent too slow/fast, and the subsequent ones
        to be sent too fast/slow so the RFC says that it must not drift. So we will check the average delay
...

Testing the test | all-jobs-are-green   View in Datadog   GitHub Actions

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1dcae11 | Docs | Datadog PR Page | Give us feedback!

@dd-oleksii dd-oleksii requested review from a team, greghuels and sameerank and removed request for a team June 10, 2026 13:50
@dd-oleksii dd-oleksii force-pushed the oleksii/jj-mlzqxpztyuqk branch from d850d2c to a88ab8b Compare June 10, 2026 15:23
@dd-oleksii dd-oleksii force-pushed the oleksii/jj-mlzqxpztyuqk branch from a88ab8b to 1b0ad90 Compare June 25, 2026 00:28
@dd-oleksii dd-oleksii force-pushed the oleksii/jj-mlzqxpztyuqk branch from 1b0ad90 to c304aa6 Compare June 25, 2026 00:57
gh-worker-dd-mergequeue-cf854d Bot pushed a commit to DataDog/dd-trace-go that referenced this pull request Jul 1, 2026
<!--
* New contributors are highly encouraged to read our
  [CONTRIBUTING](/CONTRIBUTING.md) documentation.
* Commit and PR titles should be prefixed with the general area of the pull request's change.

-->
### What does this PR do?

<!--
* A brief description of the change being made with this pull request.
* If the description here cannot be expressed in a succinct form, consider
  opening multiple pull requests instead of a single one.
-->
Add an optional integration between openfeature and tracer that adds feature flag evaluation details as span tags. These are later decoded by the backend to associate traces with experiments. [More details in RFC](https://docs.google.com/document/d/1rtO4uCZ0-y5iLfNkKjIbHqWpx2qF4cHZV13ENafuomk/edit?tab=t.0#).

### Motivation

<!--
* What inspired you to submit this pull request?
* Link any related GitHub issues or PRs here.
* If this resolves a GitHub issue, include "Fixes #XXXX" to link the issue and auto-close it on merge.
-->
This deepens integration between FFE (feature flagging and experimentation) and APM, and allows users to run experiments on APM-generated metrics.

### Reviewer's Checklist
<!--
* Authors can use this list as a reference to ensure that there are no problems
  during the review but the signing off is to be done by the reviewer(s).
-->

- [ ] Changed code has unit tests for its functionality at or near 100% coverage.
- [X] [System-Tests](https://github.com/DataDog/system-tests/) covering this feature have been added and enabled with the va.b.c-dev version tag. DataDog/system-tests#7125
- [ ] There is a benchmark for any new code, or changes to existing code.
- [X] If this interacts with the agent in a new way, a system test has been added.
- [X] New code is free of linting errors. You can check this by running `make lint` locally.
- [X] New code doesn't break existing tests. You can check this by running `make test` locally.
- [X] Add an appropriate team label so this PR gets put in the right place for the release notes.
- [X] All generated files are up to date. You can check this by running `make generate` locally.
- [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @/DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running `make fix-modules` locally.

Unsure? Have a question? Request a review!


Co-authored-by: benjamin.debernardi <benjamin.debernardi@datadoghq.com>
darccio pushed a commit to DataDog/dd-trace-go that referenced this pull request Jul 1, 2026
<!--
* New contributors are highly encouraged to read our
  [CONTRIBUTING](/CONTRIBUTING.md) documentation.
* Commit and PR titles should be prefixed with the general area of the pull request's change.

-->
### What does this PR do?

<!--
* A brief description of the change being made with this pull request.
* If the description here cannot be expressed in a succinct form, consider
  opening multiple pull requests instead of a single one.
-->
Add an optional integration between openfeature and tracer that adds feature flag evaluation details as span tags. These are later decoded by the backend to associate traces with experiments. [More details in RFC](https://docs.google.com/document/d/1rtO4uCZ0-y5iLfNkKjIbHqWpx2qF4cHZV13ENafuomk/edit?tab=t.0#).

### Motivation

<!--
* What inspired you to submit this pull request?
* Link any related GitHub issues or PRs here.
* If this resolves a GitHub issue, include "Fixes #XXXX" to link the issue and auto-close it on merge.
-->
This deepens integration between FFE (feature flagging and experimentation) and APM, and allows users to run experiments on APM-generated metrics.

### Reviewer's Checklist
<!--
* Authors can use this list as a reference to ensure that there are no problems
  during the review but the signing off is to be done by the reviewer(s).
-->

- [ ] Changed code has unit tests for its functionality at or near 100% coverage.
- [X] [System-Tests](https://github.com/DataDog/system-tests/) covering this feature have been added and enabled with the va.b.c-dev version tag. DataDog/system-tests#7125
- [ ] There is a benchmark for any new code, or changes to existing code.
- [X] If this interacts with the agent in a new way, a system test has been added.
- [X] New code is free of linting errors. You can check this by running `make lint` locally.
- [X] New code doesn't break existing tests. You can check this by running `make test` locally.
- [X] Add an appropriate team label so this PR gets put in the right place for the release notes.
- [X] All generated files are up to date. You can check this by running `make generate` locally.
- [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @/DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running `make fix-modules` locally.

Unsure? Have a question? Request a review!


Co-authored-by: benjamin.debernardi <benjamin.debernardi@datadoghq.com>
@dd-oleksii dd-oleksii changed the title ffe/go: enable span enrichment tests [golang@oleksii/span-enrichment] ffe/go: enable span enrichment tests Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant