Skip to content

Fix the oci_push runfiles with the new transitive blob_indices support #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BryceBeagle merged 1 commit into from
Sep 9, 2026
+6 −4
Merged

Fix the oci_push runfiles with the new transitive blob_indices support #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions oci/push.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,14 @@ done
is_executable = True,
)

runfiles = ctx.runfiles(

@BryceBeagle BryceBeagle Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also change this to use runfiles properly. Using .to_list() was definitely wrong

files = [toolchain.sdk.ocitool, ctx.attr.manifest[OCIDescriptor].descriptor_file, digest_file, tag_file],
transitive_files = depset(transitive = [layout.files, layout.transitive_blob_indices]),
)

return [
DefaultInfo(
runfiles = ctx.runfiles(
files = layout.files.to_list() +
[toolchain.sdk.ocitool, ctx.attr.manifest[OCIDescriptor].descriptor_file, digest_file, tag_file],
),
runfiles = runfiles,
),
OCIReferenceInfo(
registry = ctx.attr.registry,
Expand Down
Loading