Skip to content

Apply repro spring boot parent - #620

Closed
piloulacdog wants to merge 28 commits into
DataDog:masterfrom
muh-nee:pierrelouis.lacorte/SCRS-2569-repro-spring-boot-parent
Closed

piloulacdog wants to merge 28 commits into
DataDog:masterfrom
muh-nee:pierrelouis.lacorte/SCRS-2569-repro-spring-boot-parent

Conversation

@piloulacdog

Copy link
Copy Markdown

No description provided.

@piloulacdog
piloulacdog requested a review from a team as a code owner October 21, 2026 13:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T13:58:33.718466Z e43ce8c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@piloulacdog

Copy link
Copy Markdown
Author

Closing: this was meant to target the muh-nee/sca-testing-jmxfetch fork (a synthetic SBOM-generator validation repro) and got opened against the wrong base by mistake. Not intended for the real jmxfetch repo.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e43ce8ce99

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pom.xml

<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve interpolation of the packaged version

When this project is packaged under spring-boot-starter-parent, the inherited resources-plugin configuration accepts only the parent's @...@ delimiter (useDefaultDelimiters=false), while src/main/resources/project.properties still defines version=${project.version} and the local resources block enables filtering. Consequently every produced JAR retains the literal placeholder: MetadataHelper.getVersion() returns ${project.version}, so the version command, status output, startup log, and telemetry version tag all stop reporting the artifact version. Keep ${...} enabled or convert this resource to the inherited delimiter.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant