Repository navigation
Apply repro spring boot parent - #620
piloulacdog wants to merge 28 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Closing: this was meant to target the muh-nee/sca-testing-jmxfetch fork (a synthetic SBOM-generator validation repro) and got opened against the wrong base by mistake. Not intended for the real jmxfetch repo. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e43ce8ce99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| <parent> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-parent</artifactId> |
There was a problem hiding this comment.
Preserve interpolation of the packaged version
When this project is packaged under spring-boot-starter-parent, the inherited resources-plugin configuration accepts only the parent's @...@ delimiter (useDefaultDelimiters=false), while src/main/resources/project.properties still defines version=${project.version} and the local resources block enables filtering. Consequently every produced JAR retains the literal placeholder: MetadataHelper.getVersion() returns ${project.version}, so the version command, status output, startup log, and telemetry version tag all stop reporting the artifact version. Keep ${...} enabled or convert this resource to the inherited delimiter.
Useful? React with 👍 / 👎.
No description provided.