Skip to content

test: expect GENERAL for roots of failed dependencies #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aarsilv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: expect GENERAL for roots of failed dependencies #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,12 @@ and `cases/` directory.
|-------|-------------|
| `dependent-flags` | Direct and transitive dependencies, short-circuiting, repeated prerequisites, failure propagation, depth limiting, and cycles |

In `dependent-flags`, when dependency evaluation fails (a reached prerequisite is
missing or has no assignment, the depth limit is exceeded, or a cycle is found),
the root returns the caller default with reason `ERROR` and error code `GENERAL`.
The failed prerequisite's own evaluation event keeps its specific error code, such
as `FLAG_NOT_FOUND` for a missing prerequisite.

## Origin

These fixtures originated in the Go SDK (`dd-trace-go`). This repository now
Expand Down
3 changes: 3 additions & 0 deletions evaluation-suites/dependent-flags/cases/dependent-flags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@
"flag": "dependent-atomic-error-root",
"result": {
"reason": "ERROR",
"errorCode": "GENERAL",
"value": "atomic-default"
},
"targetingKey": "dependent-atomic-error",
Expand All @@ -323,6 +324,7 @@
"flag": "dependent-depth-three-root",
"result": {
"reason": "ERROR",
"errorCode": "GENERAL",
"value": "depth-default"
},
"targetingKey": "dependent-over-depth",
Expand All @@ -335,6 +337,7 @@
"flag": "dependent-cycle-a",
"result": {
"reason": "ERROR",
"errorCode": "GENERAL",
"value": "cycle-default"
},
"targetingKey": "dependent-cycle",
Expand Down
Loading