Repository navigation
Conversation
Mock configuration endpoints that serve ufc-config.json need flag tags to apply a flag selection. flag-selection/ufc-config-tags.json lists them in the vectors' flags shape, and the validator checks that every key exists in ufc-config.json.
mark-caii
marked this pull request as ready for review
November 2, 2026 21:58
mark-caii
marked this pull request as draft
November 3, 2026 18:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Server SDKs send a flag selection on the agentless configuration request. System-tests needs its mock configuration endpoint to apply that selection to the shared
ufc-config.json. UFC responses carry no tags, though, so the mock has nothing to filter by.Jira: FFL-3567
Changes
flag-selection/ufc-config-tags.jsongives tags to threeufc-config.jsonflags (basic-flag,numeric_flag,experiment-flag), in the same{key, tags}shape as theflagsin the vectors.ci/validate-flag-selection.pychecks the file's shape and rejects any key that is missing fromufc-config.json.validate-flag-selection.ymlalso runs whenufc-config.jsonchanges.Decisions
ufc-config.json, so the UFC fixture keeps matching what the server returns.Checklist
ufc-config.jsonevaluation-cases/(no new flags)python3 ci/validate-flag-selection.pypasses, and it fails when the tags file names an unknown key.