Repository navigation
Conversation
Cover successful dependency telemetry, fail-closed propagation, and atomic exposure rollback using the existing fixture contract. Environment: Datadog workspace Co-Authored-By: Codex GPT-5 <noreply@localhost>
Move selected dependency assignments into the top-level flag map and record assignment membership on dependency evaluations. Environment: Datadog workspace Co-Authored-By: Codex GPT-5 <noreply@localhost>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the web-only dependent-flag evaluation and telemetry fixture.
No open issues 🎉
What changed in this PR
Adds a web-only precomputed-assignment fixture for client SDK testing of dependent flag evaluation and telemetry, supporting browser-based RUM enrichment checks.
Changes:
- Defines successful and failed dependency graphs with explicit prerequisite references.
- Checks successful resolution and caller-default fallback with propagated
FLAG_NOT_FOUNDerrors. - Asserts exact exposure and evaluation event counts, excluding exposures for failed or non-selected branches.
| File | Description |
|---|---|
precomputed-assignments/cases/emissions/dependent-flags.json |
Adds dependent flag assignments, expected evaluation results, and telemetry matchers scoped to web. |
Review effort: Balanced
Require dependent precomputed fixtures to preserve dependency-before-root telemetry order. Environment: Datadog workspace Co-Authored-By: Codex GPT-5 <noreply@localhost> Co-authored-by: tyler.potter <tyler.potter@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Client SDKs need a shared precomputed-assignment fixture for validating dependent flag evaluation, telemetry, and RUM enrichment through a real browser.
Changes
dependencyEvaluations.FLAG_NOT_FOUND, returns the caller default, and marks an evaluated but non-selected leaf withisPresentInAssignment: false.Decisions
Dependency assignments live in the top-level
flagsmap. Each root dependency evaluation references its flag byflagKeyand records whether it was present in the assignment, matching the precomputed response consumed by the browser SDK.The fixture is currently scoped to
web, where the dependent-assignment client implementation and RUM-FIT coverage are available.Validation
python3 ci/validate-precomputed-fixtures.py: 13 valid, 0 errors.isPresentInAssignment: true.Checklist
ufc-config.json