Skip to content

[FFL-1795] Validate rejected dependency exposure not logged #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typotter merged 1 commit into from
Oct 30, 2026
Merged

[FFL-1795] Validate rejected dependency exposure not logged #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 44 additions & 4 deletions evaluation-suites/dependent-flags/cases/dependent-flags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"variationType": "STRING"
},
{
"description": "ONE_OF does not match when the prerequisite variant key is absent from the allowed list.",
"description": "ONE_OF does not match when the prerequisite variant key is absent from the allowed list. The prerequisite retains its evaluation event but not its exposure because the containing allocation is rejected.",
"attributes": {},
"defaultValue": "caller-default",
"flag": "dependent-one-of-miss-root",
Expand All @@ -21,10 +21,30 @@
"value": "one-of-fallback"
},
"targetingKey": "dependent-one-of-miss",
"variationType": "STRING"
"variationType": "STRING",
"expectations": {
"exposures": [
{
"allocation": "fallback",
"flag": "dependent-one-of-miss-root",
"variant": "fallback"
}
],
"evaluationEvents": [
{
"flag": "dependent-leaf-on",
"errorCode": null
},
{
"flag": "dependent-one-of-miss-root",
"errorCode": null
}
],
"noUnmatchedEvents": true
}
},
{
"description": "NOT_ONE_OF does not match when the prerequisite variant key is present in the excluded list.",
"description": "NOT_ONE_OF does not match when the prerequisite variant key is present in the excluded list. The prerequisite retains its evaluation event but not its exposure because the containing allocation is rejected.",
"attributes": {},
"defaultValue": "caller-default",
"flag": "dependent-not-one-of-hit-root",
Expand All @@ -33,7 +53,27 @@
"value": "not-one-of-fallback"
},
"targetingKey": "dependent-not-one-of-hit",
"variationType": "STRING"
"variationType": "STRING",
"expectations": {
"exposures": [
{
"allocation": "fallback",
"flag": "dependent-not-one-of-hit-root",
"variant": "fallback"
}
],
"evaluationEvents": [
{
"flag": "dependent-leaf-on",
"errorCode": null
},
{
"flag": "dependent-not-one-of-hit-root",
"errorCode": null
}
],
"noUnmatchedEvents": true
}
},
{
"description": "A depth-two tree evaluates its leaf and intermediate prerequisite before matching the root.",
Expand Down