Skip to content

chore(openfeature): gate dependent flag RC capability on evaluator support - #4418

Draft
hhan2024 wants to merge 1 commit into
masterfrom
helen/dependent-flags-capabilities-php
Draft

hhan2024 wants to merge 1 commit into
masterfrom
helen/dependent-flags-capabilities-php

Conversation

@hhan2024

@hhan2024 hhan2024 commented Nov 2, 2026

Copy link
Copy Markdown

Description

Prepare the Agent Remote Configuration path to advertise FfeFlagDependentFlagVariantKeyV1 (bit 50) only when the PHP evaluator binding reports dependent-flag-variant-key-v1. The report remains empty until native evaluation, error propagation, and PHP exposure reporting are supported; the current SDK continues advertising only rules bit 46.

Follows Python RC #21336. PHP currently has no agentless feature-flag configuration transport. Its existing libdatadog pin already declares bit 50, so no dependency update or generated enum change is needed.

Added absent/unknown/supported/mixed capability tests and a regression check for the current evaluator. Rust 1.91.1 formatting and diff checks pass. Native compilation, Rust tests, and cbindgen verification remain unrun: this sparse checkout lacks initialized build submodules and workspace storage was exhausted. Keep draft until those checks pass.

Reviewer checklist

  • Native tests and cbindgen verification pass.
  • Capability activation remains gated on complete evaluation/exposure semantics.
  • Appropriate labels assigned.

Gate configuration negotiation on evaluation and exposure support; the current evaluator remains opted out.

Environment: Datadog workspace

Co-Authored-By: Codex GPT-6 <noreply@localhost>
@datadog-official

datadog-official Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 76.57% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9d1e29e | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Nov 2, 2026

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-11-02 20:14:30

Comparing candidate commit 9d1e29e in PR branch helen/dependent-flags-capabilities-php with baseline commit aad0ff1 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 1 performance regressions! Performance is the same for 220 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+79.251ns; +141.949ns] or [+5.504%; +9.858%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:LaravelBench/benchLaravelDdprof-opcache

  • unstable execution_time [-978.034µs; +544.794µs] or [-6.733%; +3.750%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant