Repository navigation
Remove Groovy from internal-api modules - #13152
Draft
AlexeyKuznetsov-DD wants to merge 1 commit into
Draft
AlexeyKuznetsov-DD wants to merge 1 commit into
AlexeyKuznetsov-DD wants to merge 1 commit into
Conversation
All internal-api tests are now Java/JUnit 5, so the internal-api module convention no longer applies the groovy plugin, Spock or CodeNarc. A temporary java-only convention backs migrated modules while the rest keep the Groovy-based one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Drops the
groovyplugin, Spock and CodeNarc from theinternal-apimodule convention (internal-api,internal-api-9,metrics-api,remote-config-api), now that their tests are all Java/JUnit 5.Motivation
Part of the Groovy-to-Java test migration: migrated modules shouldn't pay for Groovy compilation, Spock on the test classpath, or CodeNarc.
Additional Notes
internal-apitests fail once Spock is gone, because Spock was hiding the missing config agent.dd-trace-java.conventions.java-onlyconvention backs migrated modules, and unmigrated modules keepdd-trace-java.conventions.java. They should be merged once migration finishes. The shared JUnit/Mockito/TableTest dependencies moved togradle/java_test_deps.gradle, which both conventions use.groovyplugin is present, the same way Spotless already handles Groovy.ThreadUtils.runConcurrentlyloses itsgroovy.lang.Closureoverload. Groovy callers' closure literals coerce toThrowingRunnable(checked with the GroovyThreadUtilsTestand the pekko and quarkus test compiles). Checked exceptions now propagate unwrapped.objenesisgoes from 3.3 (pinned by Spock) to 3.2 (from Mockito 4.4.0).Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue🤖 Generated with Claude Code