Repository navigation
Fix internal-api-9 coverage verification - #13151
Draft
AlexeyKuznetsov-DD wants to merge 1 commit into
Draft
AlexeyKuznetsov-DD wants to merge 1 commit into
AlexeyKuznetsov-DD wants to merge 1 commit into
Conversation
Add tests for JDK9ModuleAccess, JDK9PidSupplier and JDK9ExecutableSupplier, and exclude classes whose remaining uncovered code is JVM-specific fallbacks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Makes
:internal-api:internal-api-9:jacocoTestCoverageVerificationpass. It adds tests forJDK9ModuleAccess,JDK9PidSupplierandJDK9ExecutableSupplier.Motivation
The task fails on master: the module had a single test, and four classes were below the 0.8 coverage minimum.
Additional Notes
JDK9PidSupplier,JDK9ExecutableSupplierandJDK9StackWalkerare excluded from coverage. What remains uncovered in them is JVM-specific fallback code (ProcessHandlefailures, IBM J9 frame mapping) that can't run on our test JVMs without mocking static JDK APIs. Excluding them follows the existing pattern ininternal-api(e.g.PidHelper), and keeps the module-wide minimum intact for new code.JDK9ModuleAccessTestuses a realInstrumentation(ByteBuddyAgent.install()) and fresh class loaders, so module changes don't leak into other tests. Tested on Java 11 and 21.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue🤖 Generated with Claude Code