Repository navigation
Make exposure shutdown flush test deterministic - #9401
Merged
Merged
Conversation
Co-authored-by: btthomas <9452950+btthomas@users.noreply.github.com>
Contributor
|
Bits Code status: ✅ Done Comment @DataDog to request changes |
btthomas
requested review from
greghuels and
leoromanovsky
and removed request for
a team
October 13, 2026 13:31
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
greghuels
approved these changes
Oct 13, 2026
btthomas
enabled auto-merge (squash)
October 13, 2026 13:32
![datadog-official[bot]](https://avatars.githubusercontent.com/in/1358509?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
More details
The send gates now control disposal completion without a shutdown-deadline race, and the completed static reviewer found no actionable regression in the assertions or cleanup. Full test execution remains unverified because the required .NET SDK is unavailable.
🤖 Bits Code Review · Commit 35d158f
leoromanovsky
approved these changes
Oct 13, 2026
bouwkast
reviewed
Oct 13, 2026
bouwkast
left a comment
bouwkast
left a comment
Collaborator
There was a problem hiding this comment.
Could you link me the job where this failed with the one minute timer?
From what I can see in the logs the root cause appears to be threadpool starvation caused by ConcurrentSettingsUpdateAndLeaseAcquisition_ThreadSafe and the logs I've found so far are from the prior 5s timeout.
bouwkast
approved these changes
Oct 13, 2026
bouwkast
left a comment
bouwkast
left a comment
Collaborator
There was a problem hiding this comment.
ConcurrentSettingsUpdateAndLeaseAcquisition_ThreadSafe likely needs to be moved to a non-parallel collection and can be done in a different PR (I think it is the cause of this test failing before)
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (9401) and master.
|
|||||||||||||||
| Metric | Master (Mean ± 95% CI) | Current (Mean ± 95% CI) | Change | Status |
|---|---|---|---|---|
| .NET Framework 4.8 - Bailout | ||||
| duration | 76.33 ± (76.21 - 76.58) ms | 83.14 ± (82.71 - 83.26) ms | +8.9% | ❌⬆️ |
BenchmarksBenchmark execution time: 2026-10-13 14:41:48 Comparing candidate commit 35d158f in PR branch Found 0 performance improvements and 11 performance regressions! Performance is the same for 61 metrics, 0 unstable metrics, 74 known flaky benchmarks, 52 flaky benchmarks without significant changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
DisposeFlushesEventsQueuedWhileAnEarlierBatchIsSending assumes Dispose remains blocked until the test releases the final request. However, the test configured a finite shutdown timeout. Dispose intentionally stops waiting when that deadline expires, even if a request remains blocked. If thread-pool scheduling delays the test's continuation, its assertion observes a completed Dispose task after the deadline and incorrectly reports a flush failure. The approximately five-second failed runs match the original five-second shutdown allowance.
Current master already contains #9396, which raised that allowance to one minute. That reduces the chance of failure but retains the same race. The send loop already awaits the final flush, and Dispose waits for that loop until the configured deadline; the separate bounded-shutdown test explicitly requires timeout expiry to release shutdown. This is a test synchronization issue.
Implementation details
Test coverage
Other details
PR by Bits - View session in Datadog
Comment @DataDog to request changes