Skip to content

[FeatureFlags] Return the caller's default value on every provider error - #9299

Merged
pavlokhrebto merged 3 commits into
masterfrom
pavlo.khrebto/FFL-2468/ffe-not-ready-default-value
Sep 24, 2026
Merged

[FeatureFlags] Return the caller's default value on every provider error#9299
pavlokhrebto merged 3 commits into
masterfrom
pavlo.khrebto/FFL-2468/ffe-not-ready-default-value

Conversation

@pavlokhrebto

@pavlokhrebto pavlokhrebto commented Sep 23, 2026 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

Summary of changes

  • FeatureFlagsModule.Evaluate returns the caller's default instead of null when no configuration has arrived.
  • FeatureFlagsSdk.GetResolutionDetails returns the caller's default for every evaluation that carries an error, and when the tracer is not attached.
  • Datadog.FeatureFlags.OpenFeature 2.3.1 → 2.3.2.

Reason for change

Before configuration arrives, GetStringValueAsync("flag", "fallback") returned null instead of "fallback", with PROVIDER_NOT_READY. That is the startup window every application passes through.

OpenFeature substitutes the caller's default only when a provider throws. This provider reports errors as resolution details instead, so the default must travel with the details. Three layers could have supplied it, and none did:

  1. Tracer — the module's not-ready shortcut returned null. It came in with the original SDK in [FFE] Feature Flags SDK #7896, where the error string was No config loaded. [Feature Flags] Add flag evaluation metrics via OpenFeature hook #8367 changed the string to PROVIDER_NOT_READY and kept the null. The evaluator's own not-ready path already returned defaultValue, so the two paths disagreed.
  2. Package — GetResolutionDetails never received the default. It copied whatever value the tracer returned, and returned default! when the tracer is not attached. For a string flag that is null. It came in with the package in [FFE] OpenFeature 2.x shim package #8077.
  3. OpenFeature client — it does not step in, because the provider does not throw.

The same gap also lost JSON defaults. On error the tracer hands back the caller's OpenFeature Value, which JsonToValue cannot convert, so the caller got an empty Value.

How we found it

system-tests #7496 enabled the Feature Flags configuration-source tests for .NET for the first time. On the first run, the five cold-start cases failed with {'errorCode': 'PROVIDER_NOT_READY', 'value': None} where they expect the default. Those tests had been missing_feature for .NET, and the unit tests on this path asserted only the error, never the value, so nothing had covered it.

Implementation details

The package is the layer that owns the rule: any evaluation with an error type resolves to the caller's default. The tracer fix is still needed on its own, because it ships with the tracer, while the package reaches customers only when they upgrade it.

Resolve<T> now takes T defaultValue instead of object?. No CallTarget instruments Resolve, so changing the signature is safe.

Test coverage

Evaluate_WhenNoConfigurationYet_ReturnsTheDefaultValue covers string, boolean, integer and numeric flags, and asserts the value. The package has no unit-test project. The system-tests cold-start cases cover the not-ready path end to end.

Other details

Jira: FFL-3325

Delivery: the tracer fix ships in the next tracer release. The package fix needs Datadog.FeatureFlags.OpenFeature 2.3.2.

@pavlokhrebto pavlokhrebto changed the title Pavlo.khrebto/ffl 2468/ffe not ready default value [FeatureFlags] Return the caller's default value on every provider error Sep 23, 2026
@pavlokhrebto pavlokhrebto added type:bug AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos feature_flags labels Sep 23, 2026
@pr-commenter

pr-commenter Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-23 16:09:33

Comparing candidate commit abe6e65 in PR branch pavlo.khrebto/FFL-2468/ffe-not-ready-default-value with baseline commit 592114c in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 11 performance regressions! Performance is the same for 61 metrics, 0 unstable metrics, 70 known flaky benchmarks, 56 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.290%; +9.300%]
  • 🟥 throughput [-34179.999op/s; -30894.474op/s] or [-9.627%; -8.701%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.939%; +8.950%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.009%; +9.021%]
  • 🟥 throughput [-40541.964op/s; -32522.242op/s] or [-10.021%; -8.039%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 allocated_mem [+295 bytes; +296 bytes] or [+10.163%; +10.175%]
  • 🟥 throughput [-9769.847op/s; -9436.417op/s] or [-11.153%; -10.772%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net6.0

  • 🟥 allocated_mem [+191 bytes; +192 bytes] or [+9.052%; +9.064%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync netcoreapp3.1

  • 🟥 allocated_mem [+191 bytes; +192 bytes] or [+7.267%; +7.279%]
  • 🟥 throughput [-11980.823op/s; -10547.106op/s] or [-9.507%; -8.370%]

scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog net472

  • 🟥 throughput [-7984.943op/s; -7300.807op/s] or [-6.117%; -5.593%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-10249.032op/s; -9783.929op/s] or [-12.152%; -11.601%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • 🟥 throughput [-11303.157op/s; -8324.901op/s] or [-9.501%; -6.997%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-13608.774op/s; -11939.937op/s] or [-13.837%; -12.140%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 allocated_mem [+1.541KB; +1.541KB] or [+46.817%; +46.831%]
  • 🟥 execution_time [+307.931ms; +311.082ms] or [+152.806%; +154.370%]
  • 🟥 throughput [-57.040op/s; -52.555op/s] or [-10.263%; -9.456%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 allocated_mem [+1.011KB; +1.011KB] or [+37.485%; +37.498%]
  • 🟥 execution_time [+376.141ms; +380.786ms] or [+297.175%; +300.845%]
  • 🟩 throughput [+61.676op/s; +69.255op/s] or [+8.132%; +9.131%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 allocated_mem [+1.088KB; +1.088KB] or [+40.343%; +40.355%]
  • 🟥 execution_time [+393.854ms; +399.306ms] or [+348.545%; +353.370%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+4.749KB; +4.749KB] or [+99.967%; +99.982%]
  • 🟥 throughput [-60429.267op/s; -60003.995op/s] or [-47.017%; -46.686%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.872KB; +3.872KB] or [+81.884%; +81.895%]
  • 🟩 execution_time [-15.916ms; -11.726ms] or [-7.433%; -5.476%]
  • 🟥 throughput [-61368.671op/s; -58598.844op/s] or [-44.796%; -42.774%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+4.600KB; +4.600KB] or [+99.468%; +99.481%]
  • 🟥 throughput [-49087.166op/s; -46828.930op/s] or [-44.380%; -42.339%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.372KB; +1.372KB] or [+111.007%; +111.023%]
  • 🟥 throughput [-283619.009op/s; -279642.511op/s] or [-28.959%; -28.553%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+535 bytes; +536 bytes] or [+43.787%; +43.796%]
  • 🟩 execution_time [-26.426ms; -21.592ms] or [-11.785%; -9.629%]
  • 🟥 throughput [-99192.217op/s; -76556.669op/s] or [-10.597%; -8.179%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.336KB; +1.336KB] or [+110.585%; +110.599%]
  • 🟥 throughput [-169789.150op/s; -153812.959op/s] or [-24.395%; -22.100%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472

  • 🟥 allocated_mem [+3.378KB; +3.378KB] or [+89.003%; +89.017%]
  • 🟥 throughput [-73065.754op/s; -72270.312op/s] or [-49.172%; -48.637%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.336KB; +3.336KB] or [+88.150%; +88.161%]
  • 🟥 throughput [-74783.892op/s; -71900.825op/s] or [-47.584%; -45.749%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+3.264KB; +3.264KB] or [+88.493%; +88.506%]
  • 🟥 throughput [-56327.191op/s; -53708.473op/s] or [-44.872%; -42.786%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+185976.581op/s; +228601.740op/s] or [+6.201%; +7.623%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.975ms; -14.645ms] or [-8.747%; -6.751%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟩 allocated_mem [-13.759KB; -13.756KB] or [-42.324%; -42.316%]
  • 🟥 execution_time [+299.197ms; +299.916ms] or [+149.499%; +149.858%]
  • 🟩 throughput [+1032.457op/s; +1070.498op/s] or [+11.403%; +11.824%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+300.556ms; +303.958ms] or [+151.571%; +153.287%]
  • 🟩 throughput [+2248.275op/s; +2469.283op/s] or [+17.196%; +18.886%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+300.512ms; +302.915ms] or [+151.375%; +152.585%]
  • 🟩 throughput [+1791.416op/s; +1916.587op/s] or [+17.295%; +18.504%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+296.872ms; +298.248ms] or [+145.812%; +146.488%]
  • 🟩 throughput [+589.862op/s; +600.916op/s] or [+15.637%; +15.930%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+296.918ms; +298.482ms] or [+145.152%; +145.917%]
  • 🟩 throughput [+2870.197op/s; +2923.874op/s] or [+41.699%; +42.478%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+301.562ms; +302.679ms] or [+150.721%; +151.279%]
  • 🟩 throughput [+1407.657op/s; +1438.795op/s] or [+27.941%; +28.559%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472

  • 🟩 execution_time [-147.749µs; -143.819µs] or [-30.335%; -29.528%]
  • 🟩 throughput [+864.567op/s; +890.579op/s] or [+42.108%; +43.375%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0

  • 🟩 execution_time [-132.281µs; -105.170µs] or [-30.339%; -24.121%]
  • 🟩 throughput [+789.199op/s; +919.947op/s] or [+34.311%; +39.996%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • 🟩 execution_time [-142.718µs; -120.710µs] or [-30.578%; -25.862%]
  • 🟩 throughput [+777.514op/s; +860.611op/s] or [+35.892%; +39.728%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472

  • 🟩 execution_time [-126.355µs; -121.401µs] or [-34.115%; -32.777%]
  • 🟩 throughput [+1327.976op/s; +1390.835op/s] or [+49.182%; +51.510%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟩 execution_time [-98.102µs; -74.373µs] or [-31.319%; -23.743%]
  • 🟩 throughput [+1096.681op/s; +1303.545op/s] or [+34.187%; +40.635%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1

  • 🟩 execution_time [-136.670µs; -114.290µs] or [-37.388%; -31.265%]
  • 🟩 throughput [+1311.352op/s; +1447.866op/s] or [+47.059%; +51.958%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.269ms; +300.053ms] or [+149.366%; +149.757%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+324.518ms; +385.105ms] or [+352.602%; +418.432%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+295.726ms; +347.918ms] or [+224.542%; +264.171%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • unstable execution_time [+226.843ms; +287.504ms] or [+104.300%; +132.192%]
  • 🟥 throughput [-584.778op/s; -527.197op/s] or [-52.987%; -47.769%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+140.674ms; +285.848ms] or [+59.950%; +121.816%]
  • 🟥 throughput [-670.647op/s; -587.097op/s] or [-44.732%; -39.160%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • unstable execution_time [+265.101ms; +327.822ms] or [+158.561%; +196.076%]
  • 🟥 throughput [-424.248op/s; -385.680op/s] or [-29.540%; -26.854%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1

  • unstable throughput [+0.240op/s; +113.015op/s] or [+0.045%; +21.095%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-156.559µs; -120.926µs] or [-7.931%; -6.126%]
  • 🟩 throughput [+34.240op/s; +43.481op/s] or [+6.759%; +8.583%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 allocated_mem [+88 bytes; +89 bytes] or [+11.094%; +11.104%]
  • 🟥 execution_time [+301.652ms; +303.621ms] or [+151.906%; +152.898%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+11.101%; +11.112%]
  • 🟥 execution_time [+299.781ms; +304.763ms] or [+150.221%; +152.717%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+11.101%; +11.112%]
  • 🟥 execution_time [+303.281ms; +307.186ms] or [+152.355%; +154.317%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+10.235%; +10.247%]
  • 🟥 execution_time [+301.342ms; +303.556ms] or [+151.324%; +152.436%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+11.451%; +11.465%]
  • 🟥 execution_time [+301.160ms; +303.793ms] or [+148.910%; +150.212%]
  • 🟥 throughput [-50570.430op/s; -43639.804op/s] or [-8.148%; -7.031%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+10.469%; +10.481%]
  • 🟥 execution_time [+302.254ms; +306.020ms] or [+153.196%; +155.104%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 allocated_mem [+88 bytes; +89 bytes] or [+10.268%; +10.280%]
  • 🟥 execution_time [+301.128ms; +303.119ms] or [+151.139%; +152.139%]
  • 🟥 throughput [-27882.098op/s; -25549.171op/s] or [-7.233%; -6.628%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.730%; +9.743%]
  • 🟥 execution_time [+300.555ms; +303.246ms] or [+149.799%; +151.141%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.730%; +9.743%]
  • 🟥 execution_time [+299.323ms; +302.774ms] or [+148.911%; +150.628%]
  • 🟥 throughput [-38078.574op/s; -32126.427op/s] or [-9.013%; -7.604%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472

  • 🟥 allocated_mem [+88 bytes; +89 bytes] or [+5.504%; +5.513%]
  • 🟥 throughput [-20266.563op/s; -19089.710op/s] or [-8.150%; -7.676%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+5.160%; +5.169%]
  • 🟩 execution_time [-16.288ms; -12.616ms] or [-7.574%; -5.866%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+5.136%; +5.148%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+12.045µs; +55.889µs] or [+2.975%; +13.805%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-21.082KB; -21.059KB] or [-7.690%; -7.682%]
  • unstable execution_time [-21.578µs; +36.453µs] or [-4.265%; +7.205%]
  • unstable throughput [-131.985op/s; +69.453op/s] or [-6.586%; +3.466%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • unstable execution_time [+2.412µs; +151.535µs] or [+0.418%; +26.260%]
  • unstable throughput [-197.202op/s; +83.226op/s] or [-11.266%; +4.755%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • 🟥 execution_time [+5.713µs; +9.530µs] or [+13.503%; +22.526%]
  • 🟥 throughput [-4530.801op/s; -2764.762op/s] or [-19.073%; -11.639%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-15.940µs; -8.674µs] or [-24.730%; -13.458%]
  • 🟩 throughput [+2280.492op/s; +3810.358op/s] or [+13.992%; +23.378%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+303.606ms; +305.262ms] or [+153.459%; +154.296%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+306.830ms; +310.947ms] or [+156.176%; +158.271%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+300.523ms; +304.194ms] or [+150.449%; +152.287%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.432%; +8.443%]
  • 🟥 throughput [-45224.961op/s; -41606.058op/s] or [-12.520%; -11.518%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.456%; +8.467%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.456%; +8.466%]
  • 🟥 throughput [-36290.968op/s; -27523.420op/s] or [-8.589%; -6.514%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+296.475ms; +298.758ms] or [+147.766%; +148.904%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 allocated_mem [+88 bytes; +88 bytes] or [+5.502%; +5.512%]
  • 🟥 execution_time [+300.836ms; +304.380ms] or [+151.066%; +152.845%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+5.333%; +5.343%]
  • 🟥 execution_time [+302.912ms; +305.137ms] or [+153.617%; +154.746%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+299.777ms; +301.009ms] or [+149.531%; +150.145%]
  • 🟩 throughput [+61060612.210op/s; +61414136.582op/s] or [+44.468%; +44.726%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+421.387ms; +427.740ms] or [+524.070%; +531.971%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+298.911ms; +300.057ms] or [+149.090%; +149.661%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472

  • 🟥 throughput [-62515.295op/s; -58715.867op/s] or [-5.723%; -5.375%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+14.421%; +14.433%]
  • 🟥 throughput [-90388.159op/s; -84930.757op/s] or [-13.229%; -12.430%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+13.576%; +13.589%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+13.576%; +13.587%]
  • 🟥 throughput [-83676.296op/s; -66180.440op/s] or [-11.683%; -9.240%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (9299) and master.

✅ No regressions detected

📄 View the full report (charts + all metrics) →

@pavlokhrebto pavlokhrebto mentioned this pull request Sep 23, 2026
Merged
5 tasks
leoromanovsky
leoromanovsky approved these changes Sep 23, 2026
View reviewed changes

@leoromanovsky leoromanovsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pavlokhrebto
pavlokhrebto marked this pull request as ready for review September 24, 2026 08:20
@pavlokhrebto
pavlokhrebto requested review from a team as code owners September 24, 2026 08:20
@pavlokhrebto
pavlokhrebto requested review from andrewlock, danyal002 and sameerank and removed request for a team and danyal002 September 24, 2026 08:20
@pavlokhrebto
pavlokhrebto merged commit 7647840 into master Sep 24, 2026
147 checks passed
@pavlokhrebto
pavlokhrebto deleted the pavlo.khrebto/FFL-2468/ffe-not-ready-default-value branch September 24, 2026 13:24
@github-actions github-actions Bot added this to the vNext-v3 milestone Sep 24, 2026
@aarsilv aarsilv mentioned this pull request Oct 18, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leoromanovsky leoromanovsky leoromanovsky approved these changes
@andrewlock andrewlock andrewlock approved these changes
@sameerank sameerank Awaiting requested review from sameerank sameerank is a code owner automatically assigned from DataDog/feature-flagging-and-experimentation-sdk

Assignees

No one assigned

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos feature_flags type:bug

Projects

None yet

Milestone

3.55.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavlokhrebto @leoromanovsky @andrewlock