Repository navigation
RUM-19625: Accept custom attributes in _RumInternalProxy.addLongTask - #4112
ambushwork wants to merge 1 commit into
Conversation
Add an optional attributes parameter to _RumInternalProxy.addLongTask and pass it through AdvancedRumMonitor and RumRawEvent.AddLongTask into the long task event context. The map is copied before queueing. Regenerate api files.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 294fbd9801
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ambushwork
added
the
ready-for-human-review
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
![datadog-prod-us1-6[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
Long-task attributes are copied before queueing and merged over parent and view attributes, with the reserved target applied last. The completed static review found no actionable defects in this behavior.
🤖 Bits Code Review · Commit 294fbd9
awforsythe
left a comment
awforsythe
left a comment
There was a problem hiding this comment.
Incredible! Thanks for taking care of this.
What does this PR do?
Adds an optional
attributes: Map<String, Any?> = emptyMap()parameter to_RumInternalProxy.addLongTask. The parameter is also added toAdvancedRumMonitor,DatadogRumMonitorandRumRawEvent.AddLongTask. The attributes are merged into the long task event context, on top of the parent and view attributes.RumAttributes.LONG_TASK_TARGETis applied last, so it can't be overwritten. The monitor copies the map (toMap()) before queueing, so if the caller changes the map afterwards, the event keeps the original values.api/apiSurfaceandapi/dd-sdk-android-rum.apiare regenerated.Motivation
[RUM-19625](https://datadoghq.atlassian.net/browse/RUM-19625): cross-platform SDKs need to attach custom attributes to long tasks they report through the internal proxy. This unblocks [RUM-19626](https://datadoghq.atlassian.net/browse/RUM-19626).
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)