[ambushwork]

What does this PR do?

Updates the sdk-tests skill (ai/skills/sdk-tests/SKILL.md):

• Removes the "no region comments" and "no inline comments in test bodies" rules.
• Adds a rule to use argumentCaptor and assert individual fields, never argThat { … }.
• Adds a rule to import Mockito/AssertJ symbols instead of writing fully qualified names inline.
• Adds "omit defaults" to the matcher guidance: no times(1), no eq() when every matcher would be eq, and never() instead of times(0).
• Adds a rule to use the most specific assertion (isTrue()/isFalse(), isEqualTo(list) for deterministic order).
• Adds a rule to assert the message, not only the level and target, when verifying log calls.

Motivation

An audit of the skill against existing tests showed the region and inline-comment rules conflict with thousands of existing lines. The new rules record conventions reviewers keep enforcing.

Review checklist (to be filled by reviewers)

• Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
• Make sure you discussed the feature or bugfix with the maintaining team in an Issue
• Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-05T13:51:14.575697Z	d175e79	New commits
🔒 Security Review	✅ Completed 2026-11-05T13:51:53.361943Z	d175e79	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[datadog-datadog-prod-us1]

 

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 72.12% (-0.04%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d175e79 | Docs | View more details | Give us feedback!}

[datadog-datadog-prod-us1]

More details

The captor, matcher, and logger-message assertion guidance is consistent with existing test utilities and repository conventions.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 9cdb568}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9cdb568733

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[kikoveiga]

This is nice! Both the imports rule and argumentCaptor vs argThat are important for AI to follow.

As more and more code is generated, we can think about improving or transferring these guidelines into hard detekt rules. This reminds me of PreferTimeProvider or other custom detekt rules we have, also working on enabling an UnnecessaryFullyQualifiedName detekt rule in #4105.

[0xnm]

there is a certain repetition, because it is already mentioned in AGENTS.md. I think we can restructure AGENTS.md to cut the stuff which is in the skills. We need to have proper forwarding.

[ambushwork]

True, seems there is a whole section overlaps with this file