Skip to content

PANA-8614: Integrate host decomposition into native capture - #4092

Merged
jonathanmos merged 1 commit into
feature/sr-new-pipelinefrom
jmoskovich/04-sr-new-pipeline-part3
Nov 5, 2026
Merged

jonathanmos merged 1 commit into
feature/sr-new-pipelinefrom
jmoskovich/04-sr-new-pipeline-part3

Conversation

@jonathanmos

@jonathanmos jonathanmos commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

What does this PR do?

Add support for building mixed composition and native snapshots from copied capture data on the worker thread.

  • Assemble composition layers and wireframes alongside copied native subtrees.
  • Apply host clipping while preserving existing wireframe clipping.
  • Cull fully occluded composition content and skip mapping its embedded native subtrees.
  • Allow embedded native layers to use identities supplied by composition hosts.

Motivation

Prepare snapshot construction for host decomposition while keeping expensive processing off the UI thread. Part4 connects live View capture and the extension-provided decomposer to this support.

Additional Notes

Builds on the registration contract introduced in #4087. The Compose decomposer implementation follows in part4.

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 84.13%
• Overall Coverage: 72.41% (+0.05%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2514b28 | Docs | View more details | Give us feedback!

@jonathanmos

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T13:51:26.812072Z 2514b28 New commits
🔒 Security Review ✅ Completed 2026-11-05T13:51:47.548694Z 2514b28 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 2151372439

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2151372439

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jonathanmos
jonathanmos force-pushed the jmoskovich/04-sr-new-pipeline-part3 branch 2 times, most recently from 75a6d6e to 159c88c Compare November 3, 2026 11:08
@jonathanmos

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 159c88ce82

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jonathanmos
jonathanmos marked this pull request as ready for review November 3, 2026 11:31
@jonathanmos
jonathanmos requested review from a team as code owners November 3, 2026 11:31
@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 159c88ce82

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: FAIL

Host-bound occlusion can discard composition shadows and blur that remain visible outside the covered rectangle: clipping constrains leaf wireframes but does not constrain subsequent layer effects.

Open Bits AI session

🤖 Bits Code Review · Commit 159c88c

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 159c88ce82

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jonathanmos
jonathanmos force-pushed the jmoskovich/04-sr-new-pipeline-part3 branch from 159c88c to 1d01e2d Compare November 3, 2026 12:23

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d01e2d05a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jonathanmos
jonathanmos force-pushed the jmoskovich/04-sr-new-pipeline-part3 branch from 1d01e2d to bd85461 Compare November 3, 2026 13:30
@jonathanmos jonathanmos added the ready-for-human-review All agentic review feedback was addressed and PR is ready for the human review. label Nov 3, 2026
@maciejburda
maciejburda requested a review from hamorillo November 4, 2026 08:03
Prepare worker-side assembly, clipping, validation and occlusion handling
with direct tests over copied inputs. Share traversal test setup so live-View
integration can be reviewed separately.

Ref: PANA-8614
@jonathanmos
jonathanmos merged commit 666a068 into feature/sr-new-pipeline Nov 5, 2026
25 checks passed
@jonathanmos
jonathanmos deleted the jmoskovich/04-sr-new-pipeline-part3 branch November 5, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human-review All agentic review feedback was addressed and PR is ready for the human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants