Repository navigation
FFL-3459: Support flagSelection on Flags precompute requests #4031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
23fa314
FFL-3459: Support flagSelection on Flags precompute requests
mark-caii 845e923
FFL-3459: Tighten flag selection internals
mark-caii afba396
FFL-3459: Merge develop into flag selection branch
mark-caii d61bd6e
FFL-3459: Read the ignored header only when a selection was sent
mark-caii 9e78344
FFL-3459: Accept null lists in flagSelection
mark-caii e5562f4
FFL-3459: Document flagSelection limits and server behavior
mark-caii 6766ce9
FFL-3459: Cover the shared flag selection vectors in unit tests
mark-caii 61f6476
FFL-3459: Ignore an empty flag selection ignored header
mark-caii e9a6306
FFL-3459: Cover selection wiring, legacy caches and the trim set
mark-caii 2d05334
FFL-3459: Simplify flag selection internals and tests
mark-caii b754a44
FFL-3459: Merge develop into flag selection branch
mark-caii ec0039c
FFL-3459: Test the ignored reason with an unparseable body
mark-caii a8cfcab
FFL-3459: Assert the selection reaches the request factory
mark-caii fce8625
FFL-3459: Describe flag selection rules without backend names
mark-caii 1cc6771
FFL-3459: Document flagSelection in the module README
mark-caii d365cbb
FFL-3459: Run every shared selection vector case by name
mark-caii f80f2c3
FFL-3459: Test the ignored header name without case sensitivity
mark-caii f79b4d7
FFL-3459: Test equivalent selections and empty configurations in the …
mark-caii ca5b080
FFL-3459: Test selections with no values after canonicalization
mark-caii db50cef
FFL-3459: Drop a selection with non-string elements instead of throwing
mark-caii 765454c
FFL-3459: Remove the region markers from the flag selection client test
mark-caii ff7c444
FFL-3459: Verify the absent selection logs with verifyLog
mark-caii d29e8e3
FFL-3459: Cover every pair of the selection error order
mark-caii f68612f
FFL-3459: Keep selected flag state out of the key older SDKs read
mark-caii f10b90f
FFL-3459: Report only known DD-Flag-Selection-Ignored reasons
mark-caii 344f0f8
FFL-3459: Document unknown ignored reasons and the proxy header
mark-caii 99e58b4
FFL-3459: Rename flag presence checks to configuration checks
mark-caii e47cbe7
FFL-3459: Share the empty flags response in EvaluationsManagerTest
mark-caii 9c970b1
FFL-3459: Report an ignored selection only for an accepted response
mark-caii 75d6d26
FFL-3459: Test that interior Unicode whitespace is kept
mark-caii 28e82cd
FFL-3459: Document that the selection applies to every client and cache
mark-caii a916cb2
FFL-3459: Merge develop with the experimentation opt-out
mark-caii 00787ac
FFL-3459: Send flag selection telemetry once per process
mark-caii 161f308
FFL-3459: Report an ignored selection only when its flags are installed
mark-caii 8db220a
FFL-3459: Remove an inline comment from the opt-out key test
mark-caii e812566
FFL-3459: Merge develop into flag selection
mark-caii 9ce29b1
FFL-3459: Clarify the flag selection scope in the README
mark-caii 198c684
FFL-3459: Clarify install flow logging and model server ignored reasons
mark-caii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.