[CONTP-1965] feat(ddi): Expand supported log configurations in DDI - #3331
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intoAug 7, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b00ea32fb0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Mathew-Estafanous
force-pushed
the
mathew.estafanous/ddi-logs-config-parity
branch
from
August 6, 2026 17:02
b00ea32 to
3b6faa8
Compare
Contributor
|
/dd-review codex |
zhuminyi
approved these changes
Aug 6, 2026
Mathew-Estafanous
force-pushed
the
mathew.estafanous/ddi-logs-config-parity
branch
from
August 7, 2026 00:05
3b6faa8 to
fa0ad73
Compare
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
mathew.estafanous/ddi-logs-config-parity
branch
August 7, 2026 01:31
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Aug 7, 2026
…using DatadogInstrumentation (#54534) <!--Please give us some feedback on your experience writing this PR ! https://app.datadoghq.com/forms/43db4c02-6837-400c-8083-692e141b1b88 !--> ### What does this PR do? Points the agent to a newer datadog-operator version containing extended log configurations in the DatadogInstrumentation CRD (DataDog/datadog-operator#3331). ### Motivation Log feature parity between DDI CRD and the annotation/file based log configuration ### Describe how you validated your changes 1. Deployed operator changes with CRD: DataDog/datadog-operator#3331 2. Deployed agent and instrumentation CR using new fields. ```yaml apiVersion: datadoghq.com/v1alpha1 kind: DatadogInstrumentation metadata: name: redis namespace: cache spec: targetRef: apiVersion: apps/v1 kind: StatefulSet name: redis config: logs: - containerName: redis source: redis service: redis tags: - service:redis - env:injector-dev auto_multi_line_detection: true auto_multi_line_detection_custom_samples: - regex: '^\d+:[MSC] \d{2} [A-Z][a-z]{2} \d{4}' label: redis_timestamp - sample: "1:M 06 Aug 2026 15:04:05.000 * Ready to accept connections" label: redis_startup auto_multi_line: enable_json_detection: true enable_datetime_detection: true tokenizer_max_input_bytes: 2048 pattern_table_max_size: 100 enable_json_aggregation: false tag_aggregated_json: false stack_trace_parsers: [] fingerprint_config: fingerprint_strategy: line_checksum count: 2 count_to_skip: 0 max_bytes: 4096 max_message_size_bytes: 262144 ``` 3. Confirmed log check scheduled with configurations <img width="561" height="553" alt="image" src="https://github.com/user-attachments/assets/b3cd311f-6f01-4f81-a142-f44eb8ae8a1c" /> ### Additional Notes Co-authored-by: mathew.estafanous <mathew.estafanous@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Expands DatadogInstrumentation log configuration with additional Agent-supported options for TCP/UDP listeners, syslog parsing, automatic multiline detection, file fingerprinting, and maximum message size.
Intentionally omitted configurations
tlsconfig_id,include_user_units,exclude_user_units,include_matches,exclude_matches,container_mode,default_application_namequeryprocess_raw_messagedebug_attr_parsingauto_multi_line_sample_size,auto_multi_line_match_thresholdauto_multi_line.timestamp_detector_match_threshold,auto_multi_line.pattern_table_match_threshold, custom samplematch_thresholdexperimental_adaptive_sampling,experimental_noisy_log_detectionchannel,channel_tags,channel_tags_mutexMotivation
spec.config.logscurrently supports only a subset of Agent log configuration, preventing some Autodiscovery annotations from being migrated to DDI without losing behavior. This closes the practical workload-scoped parity gaps tracked in CONTP-1965.Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Example CR using all the new fields.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel