[TON-742] Support managed DatadogAgent creation and removal - #3268
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: df79a95 | Docs | Datadog PR Page | Give us feedback! |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7f0b3296d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b92399a8e7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
gpalmz
left a comment
There was a problem hiding this comment.
Really solid, thoroughly tested PR. Approving. Left a few comments - a couple are MED questions worth a look (the credential-guard casing bypass, the promote-reported-as-failed coupling, and the partial-stuck edge), the rest are minor.
fafb31f to
4a06cf4
Compare
…3341) Harden lifecycle readiness prerequisites Add EKS add-on lifecycle handling Generalize lifecycle ownership metadata Rename managed Agent installation support Fix managed installation lint failures Generalize managed Agent installation flow Harden managed Agent installation handoff Simplify managed Agent installation coordination Limit managed installation integration scope Preserve installation acknowledgement during uninstall Separate managed installation from Remote Config fix managed installation task arbitration harden managed Agent installation handling Improve managed installation test coverage Preserve updates when managed install is disabled Simplify managed installation flow Fix managed Windows profile validation Align managed installation namespace Harden managed installation recovery Use operator namespace for managed installs Modernize owner reference pointers Fix managed installation task recovery Harden managed installation recovery Fix managed installation cleanup retrigger ci (cherry picked from commit bf9fb87) Co-authored-by: Fanny Jiang <fanny.jiang@datadoghq.com> Co-authored-by: swang392 <sarah.wang@datadoghq.com>
What does this PR do?
Adds opt-in support for managed DatadogAgent creation and removal. The Operator reads lifecycle requests from a ConfigMap, creates or removes the DatadogAgent and Windows AgentProfile resources, and reports progress and completion through Remote Config.
The new flow coordinates with existing Fleet configuration updates so the two operations do not overwrite each other's state.
Motivation
After the EKS instrumenter installs the Operator EKS add-on, it needs a reliable way to create the DatadogAgent and confirm that removal has completed before removing the add-on.
Additional Notes
The feature is disabled by default. EKS is the first supported provider, while the managed-DatadogAgent flow remains provider-neutral and extensible. Existing DatadogAgent and DatadogAgentInternal reconciliation behavior is unchanged.
Minimum Agent Versions
Describe your test plan
CGO_ENABLED=0 go test ./cmd ./pkg/config ./pkg/fleet ./pkg/remoteconfigCGO_ENABLED=0 make lintChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel