Repository navigation
Move slack-notifier to the ab6722e build and track it with Campaigner - #1124
Open
gh-worker-campaigns-3e9aa4[bot] wants to merge 1 commit into
Open
gh-worker-campaigns-3e9aa4[bot] wants to merge 1 commit into
gh-worker-campaigns-3e9aa4[bot] wants to merge 1 commit into
Conversation
gh-worker-campaigns-3e9aa4
Bot
requested a review
from a team
as a code owner
October 26, 2026 19:53
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: a9a0fad | Docs | View more details | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repins the slack-notifier image to the current build:
v146002689-ab6722e-sdm-gbi-noblev146002692-ab6722e-sdm-gbi-jammyThe build this repo pins today falls into one of two groups:
email2slackidreads the SDShumanstable, whichwe're planning to retire in favor of Directory Service. Moving now means author
pings keep working whenever that happens.
email2slackiduses Directory Service but exitsnon-zero, with no output, for an email that has no identity (bot accounts,
the Conductor user, external co-authors). On 2026-10-19 this failed most dd-go
staging releases. ddoghq/images#12169 makes it return an empty Slack ID
instead, as the old version did.
What else changes. Where CI pinned the image in a variable or a job's
image:, the pin now lives in.gitlab/slack-notifier.engraver_versions.yaml,which your CI includes, and jobs use
$SLACK_NOTIFIER_IMAGEas before. ADockerfile that copied binaries straight from a pinned image now does it
through a named
slack-notifierstage. Both let us send future slack-notifierupdates as one-line Campaigner PRs instead of hand-made ones.
This PR is labeled
auto-merge: once you approve it and CI passes, it mergeson its own. If you'd rather merge it yourself, remove the label.
If this repo bakes slack-notifier into its own CI image (
COPY --from), thatimage needs a rebuild after merging to pick up the change, and persistent GitLab
runners need their dd-source Helm tag bumped. We're happy to help with either.
Tracking: EENG-7274, EENG-7073. Questions or concerns: #humans-sunset.