Repository navigation
CTM-679: update Galaxy VM source image and handle postgres disk 409 on retry - #4942
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4942 +/- ##
===========================================
- Coverage 73.36% 73.35% -0.02%
===========================================
Files 131 131
Lines 11314 11319 +5
Branches 927 924 -3
===========================================
+ Hits 8301 8303 +2
- Misses 3013 3016 +3
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
…exists When a previous Galaxy app creation fails after the postgres disk is created, a retry attempt would fail with AbortedException (HTTP 409) because the disk already exists. Treat this as success so the existing disk is reused and provisioning can continue. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
lol I think the title needs tweaking again |
| .asInstanceOf[com.google.api.gax.rpc.AbortedException] | ||
| .getStatusCode | ||
| .getCode | ||
| .getHttpStatusCode == 409 => |
There was a problem hiding this comment.
is the disk already existing the only case where a 409 would be returned?
There was a problem hiding this comment.
Good point, I tightened it.
LizBaldo
changed the title
…ists Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
| } | ||
| create | ||
| .recoverWith { | ||
| // The postgres disk already exists (e.g. leftover from a previous failed app creation) — safe to continue. |
There was a problem hiding this comment.
Do we need to worry about attaching to the wrong existing disk? Is the only situation where there's a pre-existing disk when previous apps fail to create?
There was a problem hiding this comment.
Good question, not really because it is per users, so if the disk is corrupted we need to delete it anyways
LizBaldo
changed the title
galaxyVm.sourceImageinreference.conftogalaxy-k8s-boot-v2026-10-15🤖 Generated with Claude Code