Skip to content

refactor: replace findable button wrappers with mui button (#4994) #4995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frano-m merged 1 commit into from
Oct 21, 2026
Merged

refactor: replace findable button wrappers with mui button (#4994) #4995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...components/Detail/components/EntityGuard/components/EntityDeprecated/entityDeprecated.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ButtonPrimary } from "@databiosphere/findable-ui/lib/components/common/Button/components/ButtonPrimary/buttonPrimary";
import { BUTTON_PROPS } from "@databiosphere/findable-ui/lib/components/common/Button/constants";
import { AlertIcon } from "@databiosphere/findable-ui/lib/components/common/CustomIcon/components/AlertIcon/alertIcon";
import { SectionActions } from "@databiosphere/findable-ui/lib/components/common/Section/section.styles";
import {
Expand All @@ -7,7 +7,7 @@ import {
} from "@databiosphere/findable-ui/lib/components/common/StatusIcon/statusIcon";
import { Override } from "@databiosphere/findable-ui/lib/config/entities";
import { TYPOGRAPHY_PROPS } from "@databiosphere/findable-ui/lib/styles/common/mui/typography";
import { Link as MLink, Typography } from "@mui/material";
import { Button, Link as MLink, Typography } from "@mui/material";
import Link from "next/link";
import { useRouter } from "next/router";
import { JSX } from "react";
Expand Down Expand Up @@ -60,7 +60,9 @@ export const EntityDeprecated = ({
</SectionContent>
<SectionActions>
<Link href="/" legacyBehavior passHref>
<ButtonPrimary href="passHref">To Homepage</ButtonPrimary>
<Button {...BUTTON_PROPS.PRIMARY_CONTAINED} href="passHref">
To Homepage
</Button>
</Link>
</SectionActions>
</Section>
Expand Down
8 changes: 5 additions & 3 deletions app/components/Detail/components/EntityGuard/components/EntityWithdrawn/entityWithdrawn.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ButtonPrimary } from "@databiosphere/findable-ui/lib/components/common/Button/components/ButtonPrimary/buttonPrimary";
import { BUTTON_PROPS } from "@databiosphere/findable-ui/lib/components/common/Button/constants";
import { AlertIcon } from "@databiosphere/findable-ui/lib/components/common/CustomIcon/components/AlertIcon/alertIcon";
import { SectionActions } from "@databiosphere/findable-ui/lib/components/common/Section/section.styles";
import {
Expand All @@ -8,7 +8,7 @@ import {
import { ANCHOR_TARGET } from "@databiosphere/findable-ui/lib/components/Links/common/entities";
import { Override } from "@databiosphere/findable-ui/lib/config/entities";
import { TYPOGRAPHY_PROPS } from "@databiosphere/findable-ui/lib/styles/common/mui/typography";
import { Link as MLink, Typography } from "@mui/material";
import { Button, Link as MLink, Typography } from "@mui/material";
import Link from "next/link";
import { JSX } from "react";
import { Notice, Section, SectionContent } from "../../entityGuard.styles";
Expand Down Expand Up @@ -58,7 +58,9 @@ export const EntityWithdrawn = ({
</SectionContent>
<SectionActions>
<Link href="/" legacyBehavior passHref>
<ButtonPrimary href="passHref">To Homepage</ButtonPrimary>
<Button {...BUTTON_PROPS.PRIMARY_CONTAINED} href="passHref">
To Homepage
</Button>
</Link>
</SectionActions>
</Section>
Expand Down
4 changes: 2 additions & 2 deletions ...MatricesTables/components/FileLocationArchivePreview/fileLocationArchivePreview.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ButtonTextPrimary } from "@databiosphere/findable-ui/lib/components/common/Button/components/ButtonTextPrimary/buttonTextPrimary";
import styled from "@emotion/styled";
import { Button } from "@mui/material";

export const FileLocationArchivePreviewButton = styled(ButtonTextPrimary)`
export const FileLocationArchivePreviewButton = styled(Button)`
font-weight: 400;
justify-self: flex-start;
`;
8 changes: 7 additions & 1 deletion ...eratedMatricesTables/components/FileLocationArchivePreview/fileLocationArchivePreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { BUTTON_PROPS } from "@databiosphere/findable-ui/lib/components/common/Button/constants";
import { JSX, useState } from "react";
import { ProjectMatrixView } from "../../../../../../viewModelBuilders/azul/hca-dcp/common/projectMatrixMapper/entities";
import { ArchivePreviewDialog } from "../ArchivePreviewDialog/archivePreviewDialog";
Expand Down Expand Up @@ -28,7 +29,12 @@ export const FileLocationArchivePreview = ({
const [loading, setLoading] = useState<boolean>(false);
return isArchivePreviewAvailable(projectMatrixView) ? (
<>
<Button onClick={(): void => setOpen(true)}>Preview Archive</Button>
<Button
{...BUTTON_PROPS.PRIMARY_TEXT}
onClick={(): void => setOpen(true)}
>
Preview Archive
</Button>
<ArchivePreviewDialog
onClose={(): void => setOpen(false)}
open={open}
Expand Down
4 changes: 2 additions & 2 deletions app/components/common/Button/components/ButtonOutline/buttonOutline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ButtonProps as DXButtonProps } from "@databiosphere/findable-ui/lib/components/common/Button/button";
import { ButtonOutline as DXButtonOutline } from "@databiosphere/findable-ui/lib/components/common/Button/components/ButtonOutline/buttonOutline";
import type { ButtonProps } from "@mui/material";
import { JSX } from "react";

export const ButtonOutline = ({ ...props }: DXButtonProps): JSX.Element => {
export const ButtonOutline = ({ ...props }: ButtonProps): JSX.Element => {
return <DXButtonOutline {...props} />;
};
Loading