Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(smu): support verified FA608WV.309 HX 370 CO readback and addressing
On this firmware, the existing RSMU 0xAF getter queries a curve and returns 600
rather than the stored CO margin. Linux also numbers the four large cores
consecutively while firmware addresses slots 0,2,4,6. The local profile uses
the firmware-derived RSMU 0x5E getter and explicit physical slot mapping.
Enable that profile only for HX 370 family/model/stepping 0x1A/0x24/0,
FA608WV.309, SMU 11.93.11.0, and the verified online SMT/L3 layout. Verify
absent-slot rejection, CO capability, all slot statuses, and signed margin
bounds before allowing writes. Other unverified Strix firmware keeps the
invalid-readback guard. The shared command sets remain unchanged.
The ryzen_smu mailbox-response fix is a prerequisite. This should be a draft
PR pending maintainer review of the exact-firmware profile and driver dependency.
Hardware evidence: three minimal -1/set/read/restore checks passed across both
groups. CoreCycler's public API separately changed Linux core 1, verified all
other cores stayed unchanged, and restored all 12 baselines to zero. No full
tuning session or effective voltage measurement was performed. Assembly
addresses, hashes, mapping, scope, and limitations are documented in
docs/strix-fa608wv309-co.md. No firmware binaries or local logs are included.
Validation: source lint passes. The broad non-slow suite returned 2919 passed,
7 skipped, and four failures. All four also fail on unchanged origin/main:
two host CPU-containment tests and two tests depending on stressapptest being
absent or resolving without an absolute path. The additional DMI-read failure
test passes; combined coverage of the modified SMU driver is 100%. Overall
coverage remains below the required 100% by one uncovered line elsewhere.
Nix checks were not run because Nix is unavailable here.
Target: https://github.com/Daaboulex/linux-corecycler
Local branch: fix/fa608wv309-co