Skip to content

Add patch registry service to fne#121

Open
lorenzolrom wants to merge 1 commit into
DVMProject:r05a06_devfrom
lorenzolrom:fne_patch_registration_service
Open

Add patch registry service to fne#121
lorenzolrom wants to merge 1 commit into
DVMProject:r05a06_devfrom
lorenzolrom:fne_patch_registration_service

Conversation

@lorenzolrom
Copy link
Copy Markdown
Contributor

No description provided.

@gatekeep
Copy link
Copy Markdown
Member

The entire PatchStatusRepository class needs review, currently it is not following proper file formatting. It requires proper file formatting: must contain proper detailed documentation blocks for functions in the header file, and proper summarized documentation blocks for functions in the source implementation file.

I question the use of std::unordered_map for potential concurrency problems, with updates to the map potentially coming from one or more sources for any reason, using std::unordered_map could cause crashes when multiple threads attempt to access the map for write simultaneously (that is insert, change, delete).

Additionally these changes don’t seem traverse the spanning tree. From a quick review, it would seem the patch registry only applies to the FNE the console is directly attached to, but does not transverse the spanning tree, as such that consoles connected on a different FNE leaf for the same system, would end up out of sync and would not show patch status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants