Skip to content

(DRAFT) Create an initial CODE_CONVENTIONS.md and CODE_STYLE.md (Frontend)#5938

Open
lgeggleston wants to merge 1 commit into
DSpace:mainfrom
lgeggleston:code_style_and_conventions
Open

(DRAFT) Create an initial CODE_CONVENTIONS.md and CODE_STYLE.md (Frontend)#5938
lgeggleston wants to merge 1 commit into
DSpace:mainfrom
lgeggleston:code_style_and_conventions

Conversation

@lgeggleston

@lgeggleston lgeggleston commented Jul 9, 2026

Copy link
Copy Markdown

References

Related to discussion that occurred in our DSpace Developer Meeting on June 25, 2026 and July 02, 2026

Related to initial Code Conventions PR created for DSpace repo: DSpace/DSpace#12739

Description

This PR creates two documentation files in our codebase:

CODE_STYLE.md is a copy of the short Angular section in the existing Code Style Guide in the wiki.
CODE_CONVENTIONS.md is a draft of a new "coding best practices" guide for the frontend which could be used by developers or reviewers as a reference for code review. I added only a few guidelines so far, based on the overarching principles described in User Interface Guidelines & Accessibility.

Instructions for Reviewers

  • Review the structure of these files and provide comment/suggestions for improvement. This was based on the initial structure in Create an initial CODE_CONVENTIONS.md to describe coding best practices. Move style guide to CODE_STYLE.md DSpace#12739, but if that doesn't work as well for dspace-angular we can absolutely change it.
  • Review the current content of these files and provide comment/suggestions for improvement.
    • Question: Would it be appropriate/helpful to copy all of the detailed design & accessibility guidelines described in https://wiki.lyrasis.org/spaces/DSDOC10x/pages/408945765/User+Interface+Design+Principles+Accessibility? For now, I just included some top level principles and a link to this wiki page, because the rules are much more numerous than the starting-out conventions for the backend, and I'm not familiar with how many are suggestions vs. rules we really want enforced. However, if developers think it's useful to copy over everything, we can certainly do so (probably grouped by topic such as buttons, notifications, layout etc.)
    • Similar question re. spelling out any linting rules in the Style Guide - would we want to highlight a set of the existing ESLint rules?

@lgeggleston lgeggleston added code task documentation Ticket describes improvements or additions to documentation labels Jul 9, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Jul 9, 2026
@lgeggleston lgeggleston requested a review from tdonohue July 9, 2026 13:55
@lgeggleston lgeggleston changed the title Create an initial CODE_CONVENTIONS.md and CODE_STYLE.md (Frontend) (DRAFT) Create an initial CODE_CONVENTIONS.md and CODE_STYLE.md (Frontend) Jul 9, 2026
@tdonohue tdonohue requested a review from atarix83 July 9, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code task documentation Ticket describes improvements or additions to documentation

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

1 participant