(DRAFT) Create an initial CODE_CONVENTIONS.md and CODE_STYLE.md (Frontend)#5938
Open
lgeggleston wants to merge 1 commit into
Open
(DRAFT) Create an initial CODE_CONVENTIONS.md and CODE_STYLE.md (Frontend)#5938lgeggleston wants to merge 1 commit into
lgeggleston wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Related to discussion that occurred in our DSpace Developer Meeting on June 25, 2026 and July 02, 2026
Related to initial Code Conventions PR created for
DSpacerepo: DSpace/DSpace#12739Description
This PR creates two documentation files in our codebase:
CODE_STYLE.mdis a copy of the short Angular section in the existing Code Style Guide in the wiki.CODE_CONVENTIONS.mdis a draft of a new "coding best practices" guide for the frontend which could be used by developers or reviewers as a reference for code review. I added only a few guidelines so far, based on the overarching principles described in User Interface Guidelines & Accessibility.Instructions for Reviewers
CODE_CONVENTIONS.mdto describe coding best practices. Move style guide toCODE_STYLE.mdDSpace#12739, but if that doesn't work as well fordspace-angularwe can absolutely change it.