Conversation
Override axios >=1.15.0 to fix NO_PROXY hostname normalization bypass leading to SSRF. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the axios version override in package.json to a range. The review feedback correctly points out that using an open-ended range for overrides can lead to non-deterministic builds and recommends pinning the version to 1.15.0 for stability.
| "overrides": { | ||
| "ws": "8.17.1", | ||
| "axios": "1.12.0", | ||
| "axios": ">=1.15.0", |
There was a problem hiding this comment.
Using an open-ended range like >=1.15.0 in pnpm.overrides can lead to non-deterministic builds and potential breaking changes if a new major version of axios is released. To maintain consistency with the other pinned overrides in this file and ensure build stability, it is recommended to pin to a specific version.
Suggested change
| "axios": ">=1.15.0", | |
| "axios": "1.15.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override axios >=1.15.0 to fix SSRF vulnerability (NO_PROXY hostname normalization bypass).