Skip to content

Add AmbientModules static integration - #948

Closed
swartzfeger wants to merge 3 commits into
DISTRHO:mainfrom
swartzfeger:feature/ambientmodules
Closed

swartzfeger wants to merge 3 commits into
DISTRHO:mainfrom
swartzfeger:feature/ambientmodules

Conversation

@swartzfeger

Copy link
Copy Markdown

No description provided.

@dromer

dromer commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Please don't add multiple plugins at the same time and stick to one per PR.

Anyway Astravox is incompatible with Cardinal as we do not allow GPL-3.0-only, so please remove it.
(it also seems completely vibecoded so I would consider that too low quality to associate the project with. Actually AmbientModules isn't that much better. We need to add some LLM statements to our contribution guide ..)

@dromer

dromer commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

I'm also not sure where these MindMeld and SurgeXT patches are coming from. Some explanation for this is warranted (and imo should also be a separate PR).

@falkTX

falkTX commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Yeah I say no to both of these, also this PR takes some liberties on how to patch code from external modules which is not nice (source builds shouldn't modify their own source during the build process, very bad practice).

Cardinal so far has been free of LLM-gen slop code, let's try to keep it that way while we can.
At some point in the future it might be impossible, but we are not there yet.

@falkTX falkTX closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants