Add new field for IP netmask

[sebix]

It's not well tested; therefore, it's a draft. Creating with a divergent netmask already works.

fixes #18

[sebix]

I'm not sure yet about the wording. "IP Network" or "IP Netmask"?

What values should it accept? I now implemented the CIDR notation because it is the simplest variant. We could also accept a leading /. Should we also accept netmask notations (255.255.255.0)?

Successfully tested so far:

• Add single device finding
• Edit Device finding
• Std Import (NMAP)
• Import (CSV)
• Create Device based on DeviceFinding
• View Device Finding
• Table view of device findings
• Split Selected
• Export (CSV)

[sebix]

Validation now removes a leading / and makes sure the netmask is >= 0 and <= 32.

Tested for: Mapping import (NMAP), Std Import (CSV), Add Device Finding and Edit Device Finding

[sebix]

Thinking about the naming again: I think ip_network is better, in line with with wording ip_address and already implies the CIDR notation.

[Crubumble]

why not a more reasonable value?

[sebix]

Because most other fields like IP addresse and mac address also have a maximum length of 1000. So, I used the existing convention.

[bernhardreiter]

Tested for

@sebix is it still "draft" or ready to merge?
(If it is ready, you can just change the status. If not: What is still to be done?)

[sebix]

Because of these:

It's not well tested; therefore, it's a draft.

Thinking about the naming again: I think ip_network is better, in line with with wording ip_address and already implies the CIDR notation.

[sebix]

And also this open question:

What values should it accept? I now implemented the CIDR notation because it is the simplest variant. We could also accept a leading /. Should we also accept netmask notations (255.255.255.0)?

[Crubumble]

Since NetBox displays the CIDR notation. CDIR notation is sufficient for now. The nomenclature has to be decided. However it also can easily be changed later. The main reason for the draft status is that some aspects are missing, which I want to add myself in the pull request

[Crubumble]

The problem with the missing netmask should be resolved right by the /findings/import/ and /findings/stdimport

in template findings_import:

• is the IP address CIDR conform?
  is a netmask column given in the data? --> use it only for ip address where it is missing
• possible to set a general netmask value (see template)
• import findings with default 24 otherwise

Use of ipAddress with the common netbox display

• show full ip address under findings and communication_finding
• adjust the matching request/lookup as well

[sebix]

TODOs here:

• If possible display the IP address and the netmask in one column as in /ipam/ip-addresses/
• extract the IP netmask from the IP address if given in the original data

[sebix]

If possible display the IP address and the netmask in one column as in /ipam/ip-addresses/

The IPAM module has one field for IP address + netmask, so this was not a reference for the code.
Implemented for all tables, based on https://django-tables2.readthedocs.io/en/latest/pages/custom-data.html#subclassing-column

extract the IP netmask from the IP address if given in the original data

Implemented as well, tested for add, edit, import and stdimport

[sebix]

Rebased on main