Repository navigation
Conversation
pmanko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack attachments previously exposed single revisions, so a real layer could have an empty diff and an unchanged snapshot could hide a child missing its updated parent. Native
--stackcollection now usesgh stack view --json, preserves each PR’s base/head range and the combined candidate, and reports freshness separately from ancestry.Reviewers assess shared design, individual layers and combined behavior, attribute findings to the owning PR, and compare prior stack versions after rebasing.
--stack-layerselects intermediate execution. Configuration comes from the trunk; publication rechecks the stack and preserves existing discussions. Provider/model and L1–L5 settings remain independent.The live campaign exposed three reporting issues now corrected: generated stack coverage IDs exclude attached consumers, out-of-scope work has visible notes separate from missing evidence, and source preparation reports missing Git objects before AI starts with useful sanitized diagnostics. Genuine missing source, unanswered questions and explicit partial reports remain incomplete; previous reports are not silently upgraded.
Validation: 95 automated tests and seven skill checks passed, including real partial-clone failure/recovery, combined and selected-layer coverage, and L2 notes that cannot clear actual omissions. Fifteen focused tests passed after the final diagnostic change; 36 local documentation links and
git diff --checkpassed. A fresh low-effort Sol L2 review of the four-PR OpenELIS installation stack plus its pinned distribution completed with 79 source inspections, valid coverage and no actionable findings. Seedocs/ogc-1560-review-harness/validation-v09.json; earlier native-stack evidence remains invalidation-v08.json.This establishes runner/reporting behavior, not full application runtime acceptance or independently measured reviewer quality. Hosted native-stack dispatch and automatic per-layer execution scheduling remain separate work; explicit CLI layer runs are supported.
Stack created with GitHub Stacks CLI • Give Feedback 💬