Release: develop -> main#3735
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
* debug: add balance tracing for BBTC investigation Add verbose logging to trace token balance values through the pipeline: - BlockchainAdapter: log when balance changes between cache updates - BlockchainAdapter: log assets missing from cache after update - BalanceService: log when saves are skipped (updated > startDate) - BalanceService: log when balance values actually change * fix: move uncached log inside !hasCache block, remove Ethereum filter - Only log uncached assets when an update was actually attempted - Log balance changes for all chains, not just Ethereum - Remove redundant chainId from log message * fix: skip initial cache log spam, add BBTC-specific trace - Only log balance changes when cache was previously populated - Add always-on BBTC (394) trace to capture Alchemy response value even when unchanged (covers the case where Alchemy returns stale data) * fix: prettier formatting * docs: add coding rules derived from David's 2,300 PR reviews Comprehensive analysis of 3,609 review comments, 274 commits, and 129 review bodies to extract coding conventions and patterns. * docs: remove raw data files, keep only CODING_RULES.md Raw JSONL analysis data kept locally only, not needed in repo. * revert: remove unrelated debug logging from PR * docs: move CODING_RULES.md to repo root * docs: fix structure, numbering, and add missing rules - Remove analysis subtitle, make it a project standard - Fix section numbering (2.2a -> 2.3, 6.4a -> 6.5) - Add missing rules: imports, trailing commas, URL construction, error message format - Clarify section comment style (// --- NAME --- //) - Clarify @DfxCron vs @Cron usage - Generalize infrastructure references * docs: merge CODING_RULES.md into CONTRIBUTING.md Single source of truth for all coding conventions and process rules. Resolves contradictions (JSON column pattern, simple-json vs getter/setter), fixes await-before-return nuance, adds build commands and migration workflow. * docs: fix remaining issues in CONTRIBUTING.md - Remove duplicate end-to-end thinking (already in PR Completeness) - Restore constraint naming algorithm table for hand-written migrations - Add explicit Avoid Eager Loading section - Add Promise.all() parallelization pattern * docs: fix DfxCron example and add missing patterns - Fix @DfxCron: has built-in locking + DisabledProcess, never combine with @lock manually - Add UpdateResult<T> entity pattern (107 usages in codebase) - Add DfxLogger (not standard NestJS Logger) - Add CachedRepository<T> for reference data - Add DtoMapper class pattern - Clarify DTO inheritance is optional, not mandatory * docs: fix fabricated code examples with real codebase patterns - Fix UserData example: use actual getters (tradingLimit, isDfxUser, hasActiveUser) instead of non-existent complete()/isDataComplete() - Fix UpdateResult example: use real setPriceInvalidStatus() instead of fabricated txReceived() - Fix DtoMapper: use ClassName.entityToDto (not this.entityToDto) - Fix mapper location: not always in dto/, remove hardcoded path * docs: fix remaining fabricated code examples - Array Methods: use real BankMapper.toDto instead of non-existent this.entityToDto instance method - .then() chains: use real PaymentLinkDtoMapper.toLinkDto and CountryDtoMapper.entitiesToDto from actual controllers - DtoMapper section: use actual PaymentLinkDtoMapper methods (toLinkDto/toLinkDtoList) instead of fabricated entityToDto * docs: use real Recall entity fields and valid TypeORM 0.3 API - Entity example now matches actual Recall entity in codebase - Fix BAD example in "Don't Load Separately" to use valid TypeORM 0.3 findOne({ where: {} }) syntax so the lesson is clearly about the pattern, not the API * fix: PR review + formatting --------- Co-authored-by: David May <david.leo.may@gmail.com>
github-actions
Bot
requested review from
TaprootFreak and
davidleomay
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist