Split SEGMENTSIZE_XY and add an autosize config#132
Open
realSquidCoder wants to merge 33 commits intoDFHack:masterfrom
Open
Split SEGMENTSIZE_XY and add an autosize config#132realSquidCoder wants to merge 33 commits intoDFHack:masterfrom
realSquidCoder wants to merge 33 commits intoDFHack:masterfrom
Conversation
|
...Weird typo in the title, though. Somewhere between 'config' and 'conifer'. WPM issue? |
realSquidCoder
changed the title
Collaborator
Author
*config, fixed now |
myk002
reviewed
Jan 14, 2025
remove AUTOSIZE_SEGMENT in favor of AUTO as a valid value for x and y segmentsizes. also removed some magic numbers
myk002
reviewed
Jan 15, 2025
Member
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
needs changelog for new feature
also added my name to the list of contributors on the splash screen
myk002
reviewed
Jan 16, 2025
myk002
reviewed
Jan 16, 2025
Co-authored-by: Myk <myk.taylor@gmail.com>
myk002
previously approved these changes
Jan 17, 2025
Member
|
there is an encoding error with the changed-but-not-changed-but-actually-changed contributors.txt file. I'll see if I can fix it up locally before merge |
Member
|
it looks like |
myk002
reviewed
Jan 17, 2025
Co-authored-by: Myk <myk.taylor@gmail.com>
Collaborator
Author
|
Should be good now |
myk002
reviewed
Jan 28, 2025
| [RESET_VIEW_OFFSET:KEY_Z] | ||
| [DECR_SEGMENT_Z:KEY_1] | ||
| [INCR_SEGMENT_Z:KEY_2] | ||
| [DECR_SEGMENT_X:KEYPAD_4] |
Member
There was a problem hiding this comment.
wherever this keybinding is handled, it's allowing the value to go negative. Same for DECR_SEGMENT_Y
Collaborator
Author
There was a problem hiding this comment.
but it... shouldn't?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #18