Repository navigation
fix(search): retain incomplete bounded rg attempts without rescanning - #165
Merged
Merged
Conversation
lx-1997
marked this pull request as ready for review
October 28, 2026 17:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bounded ripgrep attempt that times out or exits with unreadable-directory errors but no stdout currently returns null. The caller then starts a JavaScript directory walk with another budget. On the actual macOS root/HOME regression this exceeds the 30-second test cap and leaves the test process running.
Retain bounded ProcessError output even when empty, so the caller does not start another scan. Add an optional onIncomplete callback while preserving the existing array/null return shape; the built-in tools now identify incomplete output instead of claiming that no files or matches exist. Ordinary unbounded failures keep their existing fallback behavior.
Validation:
Scope: the executable fixture is POSIX-specific; Windows retains its real integration suite. This does not prove a strict end-to-end deadline for every search: post-rg file stats and the original no-rg/non-ProcessError JavaScript fallback are unchanged. An incomplete result is not proof of a complete scan or absence of matches. Full CI remains required before release.