Repository navigation
Conversation
…fix-cli-env-locale-initialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing the CLI one-shot module can crash with
Cannot access SETUP_ZH before initializationwhen exactly one provider key is discovered from the environment and the locale is Chinese. Config initializes module defaults while cli-locale is still importing config, so building the auto-provider notice accesses a translation table in the circular import before it exists.Use the existing dependency-independent
uiTexthelper for this notice. Preserve both notice templates and the other locale behavior.Validation:
npm run checkandnpm run smokepassed.The test clears inherited Moss config file/path overrides as well as provider variables. It imports modules without making real provider calls; its fetch trap is not represented as a universal network sandbox. Full CI remains required before merge/release.