Skip to content

feat(ontology): add provenance-bearing bridge sets - #855

Merged
DecisionNerd merged 13 commits into
mainfrom
feat/838-bridge-sets
Aug 21, 2026
Merged

feat(ontology): add provenance-bearing bridge sets#855
DecisionNerd merged 13 commits into
mainfrom
feat/838-bridge-sets

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add Rust-owned bridge-set lifecycle (create/import/validate/adopt/update/delete/export/reopen) with generation idempotency matching module inventory authority safety.
  • Validate bounded predicates (equivalent, related, broader/narrower, disjoint, maps_to, evidence_for), kind compatibility, endpoint presence, provenance, and minimal contradiction sets.
  • Keep shared surface hints optional; equal human names never auto-create bridges.

Closes #838

Test plan

  • cargo test -p graphforge-ontology --test bridge_sets (12 passed)
  • cargo test -p graphforge-ontology --test composition_inventory (11 passed)
  • cargo clippy -p graphforge-ontology -- -D warnings
  • CI Gate green on exact head SHA

Made with Cursor


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Implement independently versioned bridge sets with CRUD, validation,
import/adoption, conflict detection, and deterministic export for #838.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5b93d0aa-02ac-4243-b540-dc80c701f0ad

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the core Core source code changes label Aug 20, 2026
Map the new integration test into BUILD targets and the migration ledger
so Bazel Bootstrap stays fail-closed for #838.

Co-authored-by: Cursor <cursoragent@cursor.com>
@DecisionNerd

Copy link
Copy Markdown
Contributor Author

Pushed Bazel ledger/BUILD registration for bridge_sets after Bootstrap failed with cargo target missing from map: graphforge-ontology::bridge_sets.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Aug 20, 2026
DecisionNerd and others added 3 commits August 20, 2026 11:30
Use lifecycle YAML import for round-trip evidence so the integration
test links under crate_universe (serde_yaml_ng) as well as Cargo.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep both inventory_crud and bridge_sets Bazel targets/ledger rows
(cargo_target_count=110) and unify shared diagnostic codes.

Co-authored-by: Cursor <cursoragent@cursor.com>
@DecisionNerd

Copy link
Copy Markdown
Contributor Author

Merged origin/main (includes #854 / #837). Resolved conflicts in BUILD/ledger/diagnostics/lib to keep both inventory_crud and bridge_sets.

@codspeed-hq

codspeed-hq Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 17.08%

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 61 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime durable_commit 40.7 ms 94.2 ms -56.75%
Simulation transaction_classification[1] 404.8 ns 339.6 ns +19.22%
WallTime recovery_scan 21 ms 19 ms +10.54%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing feat/838-bridge-sets (c9ac081) with main (2a0fc9e)

Open in CodSpeed

@blacksmith-sh

This comment has been minimized.

@DecisionNerd
DecisionNerd merged commit 48ebd78 into main Aug 21, 2026
23 checks passed
@DecisionNerd
DecisionNerd deleted the feat/838-bridge-sets branch August 21, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core source code changes documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(ontology): add provenance-bearing bridge sets and shared semantic surfaces

1 participant