Skip to content

Added tests for JSON parsing of Time' data type#1706

Open
r-weng wants to merge 2 commits into
Courseography:masterfrom
r-weng:test-json-parsing
Open

Added tests for JSON parsing of Time' data type#1706
r-weng wants to merge 2 commits into
Courseography:masterfrom
r-weng:test-json-parsing

Conversation

@r-weng
Copy link
Copy Markdown

@r-weng r-weng commented May 16, 2026

Proposed Changes

Created a new file called TablesTests.hs in backend-test/Database, and added test cases for the FromJSON instance of the Time' data type in app/Database/Tables.hs.

The test cases check the following: empty JSON string, valid JSON string, valid JSON string with no second location, and invalid JSON string, either with no day value, no start millisofday value, no end millisofday value, no buildingCode value, or no buildingRoomNumber value.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests) X
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CircleCI checks have passed.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 0

Coverage increased (+0.5%) to 57.873%

Details

  • Coverage increased (+0.5%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3945
Covered Lines: 2340
Line Coverage: 59.32%
Relevant Branches: 964
Covered Branches: 501
Branch Coverage: 51.97%
Branches in Coverage %: Yes
Coverage Strength: 163.37 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants