Lal/fix deadlock on rollout sdcosmo 3601

[lalepee]

Add a functionality switch on setting up DB at run. The switch is on a coal config property "setup_db" at root lvl. By default this value is set to True which match the current behavior.

[Copilot]

Copilot review overview

🟡 Changes recommended

Unresolved critical and moderate issues affect schema migration, command compatibility, transaction handling, cleanup, and test coverage.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 4 · 2 · 1

Open (7)

• Add migration for legacy metadata table constraints · New
• Handle missing run configuration in metadata command · New
• Run concurrent index creation outside transactions · New
• Clean up partial data after failed dump · New
• Limit constraints to dumped nonempty tables · New
• Rename duplicate test method · New
• Use lowercase assert_called_once() in all assertions · New

What changed in this PR

Adds configurable PostgreSQL setup and per-run metadata rollout behavior.

Changes:

• Adds the root-level setup_db switch, defaulting to True.
• Refactors metadata, cleanup, foreign-key, and index setup.
• Updates tests and PostgreSQL translations.

File	Summary
tests/​unit/​coal/​test_store/​test_output/​test_postgres_channel.py	Updates channel setup and rollout tests.
tests/​unit/​coal/​test_postgresql/​test_postgresql_runner.py	Updates runner metadata tests.
cosmotech/​translation/​coal/​en-US/​coal/​store/​output/​postgres_channel.yml	Adds channel messages.
cosmotech/​translation/​coal/​en-US/​coal/​services/​postgresql.yml	Updates PostgreSQL metadata messaging.
cosmotech/​coal/​store/​output/​postgres_channel.py	Controls database setup and rollout flow.
cosmotech/​coal/​postgresql/​utils.py	Adds run-column indexes.
cosmotech/​coal/​postgresql/​store.py	Adds deferred foreign-key setup.
cosmotech/​coal/​postgresql/​runner.py	Manages run metadata lifecycle.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟡 Changes recommended

A critical SQL syntax issue and additional runtime/configuration issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

• Fix missing comma in CREATE TABLE statement · New

Resolved since last review (7)

• Clean up partial data after failed dump
• Run concurrent index creation outside transactions
• Handle missing run configuration in metadata command
• Add migration for legacy metadata table constraints
• Rename duplicate test method
• Limit constraints to dumped nonempty tables
• Use lowercase assert_called_once() in all assertions

Previously missed (1)

In code that hasn't changed since last review

Require or safely handle missing run_id

cosmotech/​coal/​store/​output/​postgres_channel.py:43

run_id is read unconditionally here, but it is not included in PostgresChannel.required_keys, so a configuration can pass is_available() and then fail only when send() runs. Add the new runtime fields to the channel's required contract or provide a backward-compatible fallback before accessing them.

This issue also appears on line 55 of the same file.