Skip to content

feat(desktop): sign Windows builds through Azure Key Vault - #534

Merged
davidmckayv merged 2 commits into
mainfrom
feat/desktop-windows-keyvault-signing
Sep 14, 2026
Merged

davidmckayv merged 2 commits into
mainfrom
feat/desktop-windows-keyvault-signing

Conversation

@davidmckayv

@davidmckayv davidmckayv commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

OpenBot’s Windows builds lacked a publisher signature. Add a protected GitHub workflow that uses the existing DigiCert certificate in Azure Key Vault to sign the app and NSIS installer. GitHub OIDC supplies authentication without an Azure password or exported private key.

A maintainer explicitly requests signing with the windows-signing label on a same-repository PR, or through manual dispatch after merge. Ordinary and fork PR builds remain unsigned. The workflow extracts the packaged app from NSIS and verifies both that payload and the installer before uploading them; Tauri restores the unsigned build executable after bundling, so checking that intermediate file would be incorrect. No release is published.

Azure federation and GitHub environment configuration are complete. Operator instructions document the setup and signing requests.

Validation:

  • Real Windows signing run passed on commit 52167c0fa38c1fc05374c3daa681da51c31136fb. Both the packaged app and installer have valid, timestamped Tawkit, Inc. signatures; SignTool reports zero warnings and errors.
  • Signed Windows artifacts and signature evidence are retained for 14 days. Downloaded app/installer SHA-256 hashes match the evidence.
  • All 24 signing regressions pass locally and on Windows, including the unsigned-intermediate regression. All 20 applicable PR checks are green, including the standard desktop matrix and zizmor.

Closes FOR-304

@linear-code

linear-code Bot commented Sep 14, 2026

Copy link
Copy Markdown

FOR-304

@davidmckayv davidmckayv added the windows-signing Request a protected signed Windows build for a same-repository PR label Sep 14, 2026
guidovizoso
guidovizoso previously approved these changes Sep 14, 2026
@davidmckayv davidmckayv added windows-signing Request a protected signed Windows build for a same-repository PR and removed windows-signing Request a protected signed Windows build for a same-repository PR labels Sep 14, 2026
@davidmckayv
davidmckayv deployed to windows-signing September 14, 2026 17:15 — with GitHub Actions Active
@davidmckayv
davidmckayv merged commit 6a8f552 into main Sep 14, 2026
24 checks passed
@davidmckayv
davidmckayv deleted the feat/desktop-windows-keyvault-signing branch September 14, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

windows-signing Request a protected signed Windows build for a same-repository PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants