feat(cluster-templates): pick a per-node storage instead of one fixed…#7
Open
gabbelitoV2 wants to merge 1 commit into
Open
feat(cluster-templates): pick a per-node storage instead of one fixed…#7gabbelitoV2 wants to merge 1 commit into
gabbelitoV2 wants to merge 1 commit into
Conversation
… name
A single STORAGE name cannot fit a mixed cluster: a node installed with
ZFS has local-zfs but no local-lvm, and the previous default ("local", a
directory storage) is often not enabled for VM images at all, so
qmrestore failed on such nodes.
Selection order, evaluated on each node:
1. CF_TEMPLATE_STORAGE, when it is active on that node
2. local-lvm, then local-zfs (the standard installer storages)
3. last resort: the best active images-capable storage - local over
shared, VM-native types (lvmthin/zfspool/btrfs/rbd/lvm) over
directory storage, most free space first
The default for CF_TEMPLATE_STORAGE changes from "local" to "local-lvm"
to match what a stock Proxmox install actually uses for VM disks; nodes
without it fall through the chain above instead of failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… name
A single STORAGE name cannot fit a mixed cluster: a node installed with ZFS has local-zfs but no local-lvm, and the previous default ("local", a directory storage) is often not enabled for VM images at all, so qmrestore failed on such nodes.
Selection order, evaluated on each node:
The default for CF_TEMPLATE_STORAGE changes from "local" to "local-lvm" to match what a stock Proxmox install actually uses for VM disks; nodes without it fall through the chain above instead of failing.