perf: move loopback load origin to Rust - #35
Closed
seonghobae wants to merge 10 commits into
Closed
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34.
Verified complete succession — closed without merge credit
This historical Draft proved that Python
ThreadingHTTPServerinside k6http_req_durationpolluted gateway attribution. Its valid delta was bounded to four paths:.github/workflows/ci.yml,TEST_STRATEGY.md,tests/load/load_origin.rs, and removal oftests/load/upstream_fixture.py. It introduced a std-only Rust HTTP/1.1 measured origin and used it for both generic and routed pg-erd load without weakening 4 VUs / 400 iterations / zero HTTP failures / p95<20 msacceptance.The delta is now completely succeeded by the ordinary current stack, so this PR is closed rather than restacked or merged:
8230f8d1311adccc133b7f6ed86df441533e486ccontains notests/load/upstream_fixture.pyand its load job contains no Python invocation;tests/load/load_origin.rsis a strict superset of the historical fixture: still std-only Rust with the 64 KiB header bound, but now with bounded workers/queue, startup validation, connection-mode/service-delay controls, direct rustc tests and constraint-oriented documentation;<20 ms;cwl-pingora-pg-erd-migrationpath, and strengthens the historical contract with independent backend/frontend p95<20 msplus at least 198 samples per route;34251472731is terminal success and published exact-SHA generic and pg-erd k6 artifacts (k6-loopback-8230f8d...andk6-pg-erd-loopback-8230f8d...). Supply Chain34251472751is also terminal success.Historical #35 source/test/evidence is therefore not being discarded: every still-valid generic and pg-erd fixture/contract has been integrated or strengthened and re-executed on a verified successor. Historical capacity measurements on old descendants remain historical evidence only and are not promoted into production SLO credit.
This closure does not imply #33 or later descendants are GREEN; every changed descendant must independently reacquire exact-head execution/review. It also does not grant protected merge, immutable release, canary, cutover, rollback or legacy-removal credit.